C# CC0013 CC0014 ternary operator fix removes comments

[KristianWedberg]

Bug

C# CC0013 and CC0014 ternary operator fixes remove comments in code-cracker v1.0.3.

This CC0014 code:

int a;
if (Environment.MachineName == "Bilbo")
{
    a = 0; // Success
}
else
{
    a = 1; // Failure
}

Currently becomes this after fix applied:

a = Environment.MachineName == "Bilbo" ? 0 : 1;

And this code:

int a;
if (Environment.MachineName == "Bilbo")
    a = 0; // Success
else
    a = 1; // Failure

Currently becomes this after fix applied:

int a;
a = Environment.MachineName == "Bilbo" ? 0 : 1; // Failure

Expected output in both above cases after fix applied:

int a;
a = Environment.MachineName == "Bilbo" 
    ? 0 // Success
    : 1; // Failure

CC0013 behaves in the exact same (incorrect) way as CC0014.

As noted on other VB ternary operator fix issues, true and false comments should not be combined, since each comment almost always only apply to one of the branches.

If 'fixing the fix' properly is non-trivial, I would suggest not creating any fix suggestion at all if there are comments, rather than silently removing them.

[carloscds]

@KristianWedberg Really is non-trivial fix. My suggestion is disable this fix if you use this kind of comment.

[KristianWedberg]

This issue will certainly end up eating users comments, since few will know to look out for it. Doing this silently is... unfortunate. I would still recommend making CC0014 hidden until this issue is addressed.

[giggio]

I agree with you both, if there comments, we do not offer a diagnostic, for both CC0013 and CC0014.