Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] - Multiple attribute filters to not combine properly #210

Closed
DerEchteFeuerpfeil opened this issue Jan 13, 2023 · 1 comment · Fixed by code-kern-ai/refinery-ui-angular#105
Labels
bug Something isn't working enhancement New feature or request

Comments

@DerEchteFeuerpfeil
Copy link

Describe the bug
When filtering for more than one attribute filter, it should display the intersection of it. Currently this is not the case (see screenshot). My suspicion is that this has something to do with the "any attribute" filter setting. If condition it on actual attributes I cannot create such an inconsistent state, but am not 100% sure.

Also, if I search for a text in the "any attribute" then this bug does not happen, only if I search for a number (see GIF). There might be other combinations with different operators where this fails, though. But that might be valuable information for bug identification.

To Reproduce
Steps to reproduce the behavior:

  1. Go to data browser in AG News project
  2. Create attribute filter with "running_id" EQUAL 501
  3. Create another attribute filter with "any attribute" CONTAINS 7
  4. See error

Expected behavior
There should be no record displayed as both conditions at the same time are not true on any record

Screenshots
image
data_browser_filter_multiple_bug

Desktop (please complete the following information):

  • OS: Win11
  • Browser edge
  • Version 1.7.1

Additional context

@DerEchteFeuerpfeil DerEchteFeuerpfeil added bug Something isn't working enhancement New feature or request labels Jan 13, 2023
@lumburovskalina
Copy link
Contributor

Steps to implement:

  • What is the core solution? -->
  1. Debugging where the error occurs if it is on the FE or BE side and where exactly it happens (1h)
  2. Finding solution why the intersection does not happen (1h)
  • What problems could be expected? --> I would assume there will be some additional time for debugging/fixing especially if it is on the BE side - less known code (30min - 1h)
  • UI changes and notifications? --> no additional min/hours
    OPTIMISTIC: 2h - 2h 30min
    PESSIMISTIC: 3h
    SUM: 2h-3h

Steps for testing:

  • Testing if single filter and filters with intersection work as expected (15 minutes)

Steps for review:

  • Review (part of the whole PR)
  • Fixing comments from PR (part of the whole PR)

ESTIMATION:

  • Implementation: 2h - 3h
  • Testing: 15minutes
  • Review: (part of the whole PR)

TOTAL ESTIMATION: 2h 15 min - 3h 15 min

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants