Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RubyDNS 2.0.0 available #185

Closed
ioquatix opened this issue Apr 9, 2017 · 8 comments
Closed

RubyDNS 2.0.0 available #185

ioquatix opened this issue Apr 9, 2017 · 8 comments

Comments

@ioquatix
Copy link

ioquatix commented Apr 9, 2017

This update is a big improvement to stability, if you have time to try it out and report any issues that would be great.

It might also assist with the IPv6 issue, since that wasn't previously supported by event machine which is no longer used.

@iffyuva
Copy link
Member

iffyuva commented Apr 9, 2017

I will try it out locally next week and let you know @ioquatix . Thanks for new release 👍

@iffyuva
Copy link
Member

iffyuva commented Apr 17, 2017

hi @ioquatix , I tried new rc1 release gem, and am facing this issue

/Users/yuva/.rvm/gems/ruby-2.4.1/gems/async-dns-0.10.0/lib/async/dns/handler.rb:137:in `run': unknown keyword: listen (ArgumentError)
	from /Users/yuva/.rvm/gems/ruby-2.4.1/gems/async-dns-0.10.0/lib/async/dns/server.rb:112:in `block (2 levels) in run'
	from /Users/yuva/.rvm/gems/ruby-2.4.1/gems/async-dns-0.10.0/lib/async/dns/server.rb:111:in `each'
	from /Users/yuva/.rvm/gems/ruby-2.4.1/gems/async-dns-0.10.0/lib/async/dns/server.rb:111:in `block in run'
	from /Users/yuva/.rvm/gems/ruby-2.4.1/gems/async-0.12.0/lib/async/task.rb:70:in `block in initialize'

Any idea whats the issue? Thanks.

@ioquatix
Copy link
Author

Do you mind sharing the code you are using to setup RubyDNS?

@iffyuva
Copy link
Member

iffyuva commented Apr 17, 2017

@ioquatix
Copy link
Author

The problem is here: https://github.com/code-mancers/invoker/blob/425a5d71dd9fc19d7119d9886f6715d6b4c72305/lib/invoker/power/powerup.rb#L17

You need to remove listen: DNS.server_ports. You can either add it to the new or directly set it up in DNS#initialize.

Additionally, it won't work inside EventMachine, but it will work absolutely fine on it's own thread, and will be just as efficient since it's also using asynchronous io.

@ioquatix
Copy link
Author

@iffyuva
Copy link
Member

iffyuva commented Apr 17, 2017

Thanks for pointers @ioquatix . I don't know much internals of invoker. I will figure out when I find time.

@ioquatix ioquatix changed the title RubyDNS 2.0.0-rc1 available RubyDNS 2.0.0 available Jul 30, 2017
@ioquatix
Copy link
Author

I've just released RubyDNS 2.0.0.

Please consider updating and let me know any feedback. Thanks.

The main user visible change between rc and 2.0.0 was that the listen: option was replaced by simply suppling as the first argument.

@ioquatix ioquatix closed this as not planned Won't fix, can't repro, duplicate, stale Jun 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants