Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(cli): disabled version option #162

Merged
merged 1 commit into from
Oct 26, 2023
Merged

feat(cli): disabled version option #162

merged 1 commit into from
Oct 26, 2023

Conversation

MishaSeredenkoPushBased
Copy link
Contributor

Disabled --version option

Closes #124

matejchalk
matejchalk approved these changes Oct 26, 2023
View reviewed changes
Copy link
Collaborator

@matejchalk matejchalk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nothing major, but the convention is to write commit messages in "imperative mood", i.e. feat(cli): disable version option instead of feat(cli): disabled version option (disable instead of disabled - think of it like you're giving instructions).

Tlacenka
Tlacenka approved these changes Oct 26, 2023
View reviewed changes
Copy link
Collaborator

@Tlacenka Tlacenka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CLI no longer supports the version option.

@MishaSeredenkoPushBased MishaSeredenkoPushBased merged commit 9a5371c into main Oct 26, 2023
6 checks passed
@MishaSeredenkoPushBased MishaSeredenkoPushBased deleted the remove-version-option branch October 26, 2023 08:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Tlacenka Tlacenka Tlacenka approved these changes

@matejchalk matejchalk matejchalk approved these changes

@BioPhoton BioPhoton Awaiting requested review from BioPhoton

@vmasek vmasek Awaiting requested review from vmasek

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

remove version option
3 participants
@MishaSeredenkoPushBased @Tlacenka @matejchalk