Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(core): add esm plugin logic #248

Merged
merged 21 commits into from
Nov 15, 2023
Merged

feat(core): add esm plugin logic #248

merged 21 commits into from
Nov 15, 2023

Conversation

BioPhoton
Copy link
Collaborator

@BioPhoton BioPhoton commented Nov 14, 2023 •
edited
Loading

This PR is related to #92

⚠️ NOTICE:
This PR needs to get considered in #215 as it will simplify the way we test plugins ATM
cc @Tlacenka

It includes:

  • separate logic for default runner (RunnerConfig type)
    • add more tests to cover the adopted logic
  • add logic and tests for (RunnerFunction type)
  • Refactor Observer to OnProgress
  • refactor executePlugin logic
    • avoid duplicated parsing
    • handle runner types
    • improve types
  • resolves Cleanup runnerconfig  #177

closes #230 #177

@BioPhoton BioPhoton marked this pull request as ready for review November 14, 2023 14:26
@BioPhoton BioPhoton self-assigned this Nov 14, 2023
@BioPhoton BioPhoton added ➕ enhancement new feature or request 🧩 cli 🧩 core and removed 🧩 cli labels Nov 14, 2023
@BioPhoton BioPhoton changed the title refactor(core): add esm plugin logic feat(core): add esm plugin logic Nov 14, 2023
matejchalk
matejchalk requested changes Nov 14, 2023
View reviewed changes
packages/core/src/lib/implementation/execute-plugin.spec.ts Outdated Show resolved Hide resolved
packages/models/src/lib/global-options.ts Show resolved Hide resolved
packages/models/src/lib/plugin-config-runner.ts Outdated Show resolved Hide resolved
packages/models/src/lib/plugin-config-runner.ts Outdated Show resolved Hide resolved
packages/models/src/lib/plugin-config-runner.ts Outdated Show resolved Hide resolved
packages/models/test/fixtures/runner-config.mock.ts Outdated Show resolved Hide resolved
packages/core/src/lib/implementation/runner.ts Outdated Show resolved Hide resolved
packages/core/src/lib/implementation/runner.spec.ts Outdated Show resolved Hide resolved
@BioPhoton
Copy link
Collaborator Author

Like it!! This is a nice feature and a really good cleanup

@BioPhoton BioPhoton added this to the 2. Integration milestone Nov 14, 2023
@BioPhoton BioPhoton mentioned this pull request Nov 15, 2023
Closed
BioPhoton and others added 2 commits November 15, 2023 14:16
@BioPhoton @matejchalk
Update packages/core/src/lib/implementation/execute-plugin.ts
8e59953 
Co-authored-by: Matěj Chalk <34691111+matejchalk@users.noreply.github.com>
@BioPhoton
refactor: implement review
8ea1fc1
BioPhoton
BioPhoton commented Nov 15, 2023
View reviewed changes
Copy link
Collaborator Author

@BioPhoton BioPhoton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I implemented all changes

@Tlacenka Tlacenka mentioned this pull request Nov 15, 2023
Closed
20 tasks
@BioPhoton BioPhoton merged commit 18d4e3a into main Nov 15, 2023
11 checks passed
@BioPhoton BioPhoton deleted the esm-plugin-logic branch November 15, 2023 15:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matejchalk matejchalk matejchalk approved these changes

Assignees

@BioPhoton BioPhoton

Labels
🧩 core ➕ enhancement new feature or request
Projects
None yet
Milestone
2. Integration
Development

Successfully merging this pull request may close these issues.

Introduce new type for runner Cleanup runnerconfig
2 participants
@BioPhoton @matejchalk