Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(cli): setup yargs for cli #42

Merged
merged 15 commits into from
Sep 8, 2023
Merged

feat(cli): setup yargs for cli #42

merged 15 commits into from
Sep 8, 2023

Conversation

BioPhoton
Copy link
Collaborator

@BioPhoton BioPhoton commented Sep 7, 2023 •
edited
Loading

This PR includes:

  • yargs setup
  • chalk usage
  • test cli-e2e
  • update plugins to new model structure
  • test plugins

closes #6
closes #38

BioPhoton and others added 4 commits September 7, 2023 11:19
@BioPhoton
feat(cli): rearrange files
ff7e114
@BioPhoton @matejchalk
feat(utils): add package utils for cli independent logic (#39)
409883b 
Closes #32

This PR focuses on the CLI independent logic for the collect command.

It includes:
- source code + JsDocs
- unit tests
- test helper
- mock data
- adoptions for libs (make them buildable)

---------

Co-authored-by: Matěj Chalk <34691111+matejchalk@users.noreply.github.com>
@BioPhoton
feat(cli): adopt typings
60d26b8
@BioPhoton
refactor(cli): adopt types, naming and tests
705e627
@BioPhoton
refactor(cli): adopt engine and types
fdbdf4a
@BioPhoton
Merge branch 'main' into setup-yargs-for-cli
1a9d323 
# Conflicts:
#	package-lock.json
#	packages/models/src/lib/core-config.ts
#	packages/models/src/lib/plugin-config.ts
#	packages/utils/package.json
#	packages/utils/src/lib/collect/implementation/execute-plugin.ts
@BioPhoton
refactor(plugins): adopt output data to models
3825c83
@BioPhoton
refactor(plugins): format
7308533
@BioPhoton
test(cli-e2e): fix e2e tests for new plugins
c20849b
@BioPhoton
test(cli-e2e): format
653ed21
matejchalk
matejchalk reviewed Sep 8, 2023
View reviewed changes
packages/cli/src/lib/commands.ts Show resolved Hide resolved
packages/cli/src/lib/cli.spec.ts Show resolved Hide resolved
packages/cli/src/lib/cli.spec.ts Outdated Show resolved Hide resolved
packages/cli/package.json Outdated Show resolved Hide resolved
packages/cli/src/index.ts Outdated Show resolved Hide resolved
packages/cli/src/lib/options.ts Outdated Show resolved Hide resolved
packages/models/src/lib/category-config.ts Outdated Show resolved Hide resolved
packages/models/src/lib/plugin-config.ts Outdated Show resolved Hide resolved
packages/models/src/lib/plugin-config.ts Outdated Show resolved Hide resolved
packages/models/src/lib/plugin-config.ts Outdated Show resolved Hide resolved
@BioPhoton @matejchalk
Apply suggestions from code review
d006e42 
Co-authored-by: Matěj Chalk <34691111+matejchalk@users.noreply.github.com>
vmasek
vmasek previously approved these changes Sep 8, 2023
View reviewed changes
vmasek
vmasek requested changes Sep 8, 2023
View reviewed changes
packages/cli/src/lib/cli.spec.ts Outdated Show resolved Hide resolved
matejchalk
matejchalk previously approved these changes Sep 8, 2023
View reviewed changes
@matejchalk matejchalk merged commit 37ea0a5 into main Sep 8, 2023
6 checks passed
@matejchalk matejchalk deleted the setup-yargs-for-cli branch September 8, 2023 14:51
@BioPhoton BioPhoton mentioned this pull request Oct 18, 2023
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matejchalk matejchalk matejchalk approved these changes

@vmasek vmasek Awaiting requested review from vmasek

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Consider specifying engine in package.json Set up Yargs and basic structure
3 participants
@BioPhoton @vmasek @matejchalk