Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(cli): add logger #459

Merged
merged 30 commits into from
Feb 6, 2024
Merged

feat(cli): add logger #459

merged 30 commits into from
Feb 6, 2024

Conversation

BioPhoton
Copy link
Collaborator

@BioPhoton BioPhoton commented Feb 3, 2024 •
edited
Loading

This is one of many PRs to refactor our logging related code.

It includes:

Screenshot 2024-02-03 at 13 14 22 Screenshot 2024-02-03 at 13 13 56 Screenshot 2024-02-03 at 03 30 18 Screenshot 2024-02-05 at 21 08 10

@github-actions github-actions bot added the 🔬 testing writing tests label Feb 5, 2024
@BioPhoton BioPhoton marked this pull request as ready for review February 5, 2024 14:17
@BioPhoton BioPhoton mentioned this pull request Feb 5, 2024
Closed
8 tasks
@BioPhoton BioPhoton self-assigned this Feb 5, 2024
Tlacenka
Tlacenka reviewed Feb 6, 2024
View reviewed changes
Copy link
Collaborator

@Tlacenka Tlacenka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall great improvement, like the formatting and upload suggestions in a block now 😁

packages/cli/src/lib/print-config/print-config-command.unit.test.ts Outdated Show resolved Hide resolved
packages/utils/src/lib/reports/utils.unit.test.ts Outdated Show resolved Hide resolved
packages/cli/src/lib/upload/upload-command.ts Outdated Show resolved Hide resolved
packages/utils/src/lib/reports/utils.unit.test.ts Outdated Show resolved Hide resolved
packages/utils/src/lib/reports/utils.unit.test.ts Outdated Show resolved Hide resolved
project.json Outdated Show resolved Hide resolved
project.json Outdated Show resolved Hide resolved
packages/utils/src/lib/reports/utils.ts Outdated Show resolved Hide resolved
BioPhoton and others added 7 commits February 6, 2024 13:26
@BioPhoton @Tlacenka
Update packages/utils/src/lib/reports/utils.unit.test.ts
7956f01 
Co-authored-by: Katka Pilátová <katerina.pilatova@flowup.cz>
@BioPhoton @Tlacenka
Update packages/utils/src/lib/reports/utils.unit.test.ts
b71bc3f 
Co-authored-by: Katka Pilátová <katerina.pilatova@flowup.cz>
@BioPhoton @Tlacenka
Update packages/utils/src/lib/reports/utils.unit.test.ts
17dfe63 
Co-authored-by: Katka Pilátová <katerina.pilatova@flowup.cz>
@BioPhoton @Tlacenka
Update project.json
cf714a6 
Co-authored-by: Katka Pilátová <katerina.pilatova@flowup.cz>
@BioPhoton @Tlacenka
Update project.json
3a2ae2a 
Co-authored-by: Katka Pilátová <katerina.pilatova@flowup.cz>
@BioPhoton @Tlacenka
Update packages/utils/src/lib/reports/utils.ts
2f54ba7 
Co-authored-by: Katka Pilátová <katerina.pilatova@flowup.cz>
@BioPhoton
refactor(utils): add git helper
bf14ee5
@BioPhoton BioPhoton requested review from matejchalk and removed request for Tlacenka February 6, 2024 15:46
@BioPhoton BioPhoton merged commit f436299 into main Feb 6, 2024
18 checks passed
@BioPhoton BioPhoton deleted the setup-the-logger branch February 6, 2024 15:58
@BioPhoton BioPhoton mentioned this pull request Feb 7, 2024
Closed
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Tlacenka Tlacenka Tlacenka left review comments

@matejchalk matejchalk matejchalk approved these changes

Assignees

@BioPhoton BioPhoton

Labels
🧩 cli 🧩 core 🔬 testing writing tests 🧩 utils
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

📖 Hint to run CLI and further options
3 participants
@BioPhoton @Tlacenka @matejchalk