fix(plugin-eslint): eslint startline can be zero

[markusnissl]

In case tsconfig does not contain correct setup, e.g., "strictNullChecks": true, eslint throws warnings for line "zero". The current schema does not show the warning, it just throws an internal error. This fix allows for warning on line zero to be collected for the report.

Fixes issues such as:

{
  "code": "too_small",
  "minimum": 0,
  "type": "number",
  "inclusive": false,
  "exact": false,
  "message": "Number must be greater than 0",
  "path": [
    117,
    "details",
    "issues",
    3,
    "source",
    "position",
    "startLine"
  ]
},

for issues like
0:1 warning This rule requires the strictNullChecks compiler option to be turned on to function correctly @typescript-eslint/prefer-nullish-coalescing

[nx-cloud]

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 2db0d1d. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution

---

🟥 Failed Commands
nx run-collect

✅ Successfully ran 7 targets

• nx run-many --target=deploy --dry-run
• nx version @code-pushup/cli-source --dryRun
• nx affected:e2e --parallel=3
• nx affected -t integration-test --parallel=3 --coverage.enabled
• nx affected -t unit-test --parallel=3 --coverage.enabled
• nx affected:lint --parallel=3
• nx affected:build --parallel=3

---

Sent with 💌 from NxCloud.

[matejchalk]

We don't want to consume source file links for line 0, they don't represent an actual file location so we can't create file snippets from them in the portal.

Instead, I suggest we either:

• omit the position altogether if line is 0 - similar to how we handle column 0 in fix(plugin-eslint): handle rules which emit column 0 #522
• since it's more of a configuration error than an actual problem in the source code, don't create an issue at all, instead just print a warning or throw an error

[markusnissl]

@matejchalk I changed PR to implement first solution.

While I like the second solution to throw an error, it is against the idea of "monitoring" the progress for transformation as one has e.g., to fix some projects in monorepos to have the rules in place.

[matejchalk]

Thanks for the fix 🙂