You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
When I configure a audit slug for skipAudits in the plugin options the audit is filtered out from the plugin config audits but the listed audits still show up in the audit outputs of the plugin. Therefor we had to implement the normalizeAuditOutputs function to overcome the validation.
What would you expect to happen?
That runLighthouse processes the passed flags correctly
What happened?
When I configure a audit slug for
skipAudits
in the plugin options the audit is filtered out from the plugin config audits but the listed audits still show up in the audit outputs of the plugin. Therefor we had to implement thenormalizeAuditOutputs
function to overcome the validation.What would you expect to happen?
That
runLighthouse
processes the passed flags correctlyWhat steps did you take?
Ensure original logic:
npx lighthouse https://example.com --skipAudits is-on-https --output json --output-path report.json
audits
do NOT containis-on-https
configSetings.skipAudits
is set to["is-on-https"]
Ensure cp logic:
nx code-pushup -- --onlyPlugins lighthouse
with the following plugin configurationskipAudits
is passed intorunLighthouse
audits
do NOT containis-on-https
=> the audit is presentconfigSetings.skipAudits
is set to["is-on-https"]
Related source links:
Code PushUp package version
No response
What operation system are you on?
MacOS
Node version
No response
Relevant log output
No response
The text was updated successfully, but these errors were encountered: