Issue #642: Use more standard naming for Out/OutW/OutF

They are similar to fmt.Println/fmt.Fprint/fmt.Printf so they are
renamed to Outln/Fout/Outf.

This fixes #642

cmd/crc/cmd/config/get.go

@@ -19,7 +19,7 @@ var configGetCmd = &cobra.Command{
 to the options that you set when you run the 'crc start' command.`,
 	Run: func(cmd *cobra.Command, args []string) {
 		if len(args) < 1 {
-			output.Out("Please provide a configuration property to retrieve")
+			output.Outln("Please provide a configuration property to retrieve")
 			os.Exit(1)
 		}
 		runConfigGet(args[0])
@@ -31,5 +31,5 @@ func runConfigGet(key string) {
 	if err != nil {
 		errors.ExitWithMessage(1, err.Error())
 	}
-	output.Out(key, ":", v)
+	output.Outln(key, ":", v)
 }

cmd/crc/cmd/config/set.go

@@ -36,6 +36,6 @@ func runConfigSet(key string, value interface{}) {
 	}
 
 	if setMessage != "" {
-		output.Out(setMessage)
+		output.Outln(setMessage)
 	}
 }

cmd/crc/cmd/config/unset.go

@@ -35,6 +35,6 @@ func runConfigUnset(key string) {
 	}
 
 	if unsetMsg != "" {
-		output.Out(unsetMsg)
+		output.Outln(unsetMsg)
 	}
 }

cmd/crc/cmd/console.go

@@ -52,9 +52,9 @@ func runConsole(arguments []string) {
 	}
 
 	if consoleURLMode {
-		output.Out(result.URL)
+		output.Outln(result.URL)
 		return
 	}
-	output.Out("Opening the OpenShift Web console in the default browser...")
+	output.Outln("Opening the OpenShift Web console in the default browser...")
 	_ = browser.OpenURL(result.URL)
 }

cmd/crc/cmd/delete.go

@@ -42,7 +42,7 @@ func runDelete(arguments []string) {
 	if err != nil {
 		errors.Exit(1)
 	}
-	output.Out("CodeReady Containers instance deleted")
+	output.Outln("CodeReady Containers instance deleted")
 }
 
 func deleteCache() {

cmd/crc/cmd/ip.go

@@ -32,5 +32,5 @@ func runIP(arguments []string) {
 	if err != nil {
 		errors.Exit(1)
 	}
-	output.Out(result.IP)
+	output.Outln(result.IP)
 }

cmd/crc/cmd/root.go

@@ -60,7 +60,7 @@ func runPostrun() {
 }
 
 func runRoot() {
-	output.Out("No command given")
+	output.Outln("No command given")
 }
 
 func Execute() {

cmd/crc/cmd/setup.go

@@ -34,9 +34,9 @@ func runSetup(arguments []string) {
 	}
 	preflight.SetupHost(vmDriver)
 	if constants.BundleEmbedded() {
-		output.Out("Setup is complete, you can now run 'crc start' to start a CodeReady Containers instance")
+		output.Outln("Setup is complete, you can now run 'crc start' to start a CodeReady Containers instance")
 	} else {
-		output.Out("Setup is complete, you can now run 'crc start -b $bundlename' to start a CodeReady Containers instance")
+		output.Outln("Setup is complete, you can now run 'crc start -b $bundlename' to start a CodeReady Containers instance")
 	}
 }
 

cmd/crc/cmd/start.go

@@ -62,7 +62,7 @@ func runStart(arguments []string) {
 		errors.Exit(1)
 	}
 	if commandResult.Status == "Running" {
-		output.Out("CodeReady Containers instance is running")
+		output.Outln("CodeReady Containers instance is running")
 	} else {
 		logging.Warnf("Unexpected status: %s", commandResult.Status)
 	}

cmd/crc/cmd/stop.go

@@ -35,7 +35,7 @@ func runStop(arguments []string) {
 		Name: constants.DefaultName,
 	}
 
-	output.Out("Stopping CodeReady Containers instance... this may take a few minutes")
+	output.Outln("Stopping CodeReady Containers instance... this may take a few minutes")
 	commandResult, err := machine.Stop(stopConfig)
 	if err != nil {
 		// Here we are checking the VM state and if it is still running then
@@ -53,7 +53,7 @@ func runStop(arguments []string) {
 		errors.Exit(1)
 	}
 	if commandResult.Success {
-		output.Out("CodeReady Containers instance stopped")
+		output.Outln("CodeReady Containers instance stopped")
 	} else {
 		/* If we did not get an error, the status should be true */
 		logging.Warnf("Unexpected status %v", commandResult.Success)
@@ -65,5 +65,5 @@ func killVM(killConfig machine.PowerOffConfig) {
 	if err != nil {
 		errors.Exit(1)
 	}
-	output.Out("CodeReady Containers instance forcibly stopped")
+	output.Outln("CodeReady Containers instance forcibly stopped")
 }

pkg/crc/errors/atexit.go

@@ -44,9 +44,9 @@ func Exit(code int) {
 // If the exit code is 0, the message is prints to stdout, otherwise to stderr.
 func ExitWithMessage(code int, text string, args ...interface{}) {
 	if code == 0 {
-		_, _ = output.OutW(os.Stdout, fmt.Sprintf(text, args...))
+		_, _ = output.Fout(os.Stdout, fmt.Sprintf(text, args...))
 	} else {
-		_, _ = output.OutW(os.Stderr, fmt.Sprintf(text, args...))
+		_, _ = output.Fout(os.Stderr, fmt.Sprintf(text, args...))
 	}
 	Exit(code)
 }

pkg/crc/input/input.go

@@ -13,7 +13,7 @@ func PromptUserForYesOrNo(message string, force bool) bool {
 		return true
 	}
 	var response string
-	output.OutF(message + "? [y/N]: ")
+	output.Outf(message + "? [y/N]: ")
 	fmt.Scanf("%s", &response)
 
 	return strings.ToLower(response) == "y"

pkg/crc/output/output.go

@@ -5,14 +5,14 @@ import (
 	"io"
 )
 
-func Out(args ...interface{}) {
+func Outln(args ...interface{}) {
 	fmt.Println(args...)
 }
 
-func OutF(s string, args ...interface{}) {
+func Outf(s string, args ...interface{}) {
 	fmt.Printf(s, args...)
 }
 
-func OutW(w io.Writer, args ...interface{}) (n int, err error) {
+func Fout(w io.Writer, args ...interface{}) (n int, err error) {
 	return fmt.Fprintln(w, args...)
 }

pkg/crc/services/dns/dns_windows.go

@@ -18,7 +18,7 @@ import (
 func runPostStartForOS(serviceConfig services.ServicePostStartConfig, result *services.ServicePostStartResult) (services.ServicePostStartResult, error) {
 	// bailout for Virtualbox
 	if serviceConfig.DriverName == "virtualbox" {
-		output.Out("Please follow instructions in the documentation about setting hostnames for Virtualbox.")
+		output.Outln("Please follow instructions in the documentation about setting hostnames for Virtualbox.")
 		result.Success = true
 		return *result, nil
 	}