Check that proxy URL starts with http://

go.mod

@@ -23,6 +23,7 @@ require (
 	github.com/spf13/cobra v0.0.3
 	github.com/spf13/pflag v1.0.3
 	github.com/spf13/viper v1.3.2
+	github.com/stretchr/testify v1.3.0
 	github.com/xi2/xz v0.0.0-20171230120015-48954b6210f8
 	golang.org/x/crypto v0.0.0-20190701094942-4def268fd1a4
 	golang.org/x/sys v0.0.0-20200116001909-b77594299b42

pkg/crc/network/proxy.go

@@ -133,6 +133,12 @@ func ValidateProxyURL(proxyUrl string) error {
 		return nil
 	}
 
+	if strings.HasPrefix(proxyUrl, "https://") {
+		return fmt.Errorf("Proxy URL '%s' is not valid: https is not supported", proxyUrl)
+	}
+	if !strings.HasPrefix(proxyUrl, "http://") {
+		return fmt.Errorf("Proxy URL '%s' is not valid: url should start with http://", proxyUrl)
+	}
 	if !govalidator.IsURL(proxyUrl) {
 		return fmt.Errorf("Proxy URL '%s' is not valid.", proxyUrl)
 	}

pkg/crc/network/proxy_test.go

@@ -0,0 +1,14 @@
+package network
+
+import (
+	"testing"
+
+	"github.com/stretchr/testify/assert"
+)
+
+func TestValidateProxyURL(t *testing.T) {
+	assert.NoError(t, ValidateProxyURL("http://company.com"))
+
+	assert.EqualError(t, ValidateProxyURL("company.com:8080"), "Proxy URL 'company.com:8080' is not valid: url should start with http://")
+	assert.EqualError(t, ValidateProxyURL("https://company.com"), "Proxy URL 'https://company.com' is not valid: https is not supported")
+}