Skip to content

Commit

Permalink
Issue #506 Remove check if bundle is cached for start command
Browse files Browse the repository at this point in the history
This is not needed as, if a bundle is not passed via -b flag
or not configured then start won't even reach this point. if
a bundle is configured we don't need to check if the embedded
bundle was cached as validation checks will kick in before running
preflight checks, so the check is only performed for the setup
command.
  • Loading branch information
anjannath authored and praveenkumar committed Sep 5, 2019
1 parent e6fed89 commit d61e39c
Show file tree
Hide file tree
Showing 3 changed files with 0 additions and 15 deletions.
5 changes: 0 additions & 5 deletions pkg/crc/preflight/preflight_darwin.go
Expand Up @@ -45,11 +45,6 @@ func StartPreflightChecks(vmDriver string) {
fmt.Sprintf("Checking file permissions for %s", hostFile),
config.GetBool(cmdConfig.WarnCheckResolvConfFilePermissions.Name),
)
preflightCheckSucceedsOrFails(config.GetBool(cmdConfig.SkipCheckBundleCached.Name),
checkBundleCached,
"Checking if CRC bundle is cached in '$HOME/.crc'",
config.GetBool(cmdConfig.WarnCheckBundleCached.Name),
)
}

// SetupHost performs the prerequisite checks and setups the host to run the cluster
Expand Down
5 changes: 0 additions & 5 deletions pkg/crc/preflight/preflight_linux.go
Expand Up @@ -77,11 +77,6 @@ func StartPreflightChecks(vmDriver string) {
"Checking if /etc/NetworkManager/dnsmasq.d/crc.conf exists",
config.GetBool(cmdConfig.WarnCheckCrcDnsmasqFile.Name),
)
preflightCheckSucceedsOrFails(config.GetBool(cmdConfig.SkipCheckBundleCached.Name),
checkBundleCached,
"Checking if CRC bundle is cached in '$HOME/.crc'",
config.GetBool(cmdConfig.WarnCheckBundleCached.Name),
)
}

// SetupHost performs the prerequisite checks and setups the host to run the cluster
Expand Down
5 changes: 0 additions & 5 deletions pkg/crc/preflight/preflight_windows.go
Expand Up @@ -14,11 +14,6 @@ func StartPreflightChecks(vmDriver string) {
"Checking if oc binary is cached",
false,
)
preflightCheckSucceedsOrFails(config.GetBool(cmdConfig.SkipCheckBundleCached.Name),
checkBundleCached,
"Checking if CRC bundle is cached in '$HOME/.crc'",
config.GetBool(cmdConfig.WarnCheckBundleCached.Name),
)

if vmDriver == "hyperv" {
preflightCheckSucceedsOrFails(false,
Expand Down

0 comments on commit d61e39c

Please sign in to comment.