Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

crc cleanup on macOS doesn't remove existing crc vm #1346

Closed
anjannath opened this issue Jul 1, 2020 · 5 comments · Fixed by #1658
Closed

crc cleanup on macOS doesn't remove existing crc vm #1346

anjannath opened this issue Jul 1, 2020 · 5 comments · Fixed by #1658
Assignees
@praveenkumar
Labels
kind/task Workable task os/macos size/S

Comments

@anjannath
Copy link
Member

On the other platforms (windows and linux) crc cleanup removes an existing crc vm but not in the case of macOS
@praveenkumar
Copy link
Member

It is because we don't have any management cli for hyperkit like we have for libvirt and hyperV, in this case we might need to grab the running hyperkit process and make sure it is crc related then kill it.

@anjannath
Copy link
Member Author

Ahh, just checked the removeCrcVM() for windows, and it manually deletes the vm without using the machine api, can we not use machine.Delete() from the cleanup function?

anjannath added a commit to anjannath/crc that referenced this issue Jul 9, 2020
@anjannath
Issue crc-org#1346 Fix oc-env for windows
e2f2062 
As suggested in crc-org#1346 `Invoke-Expression -Command crc oc-env`
seems to work in powershell
@praveenkumar praveenkumar self-assigned this Aug 27, 2020
@stale
Copy link

stale bot commented Oct 26, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the status/stale Issue went stale; did not receive attention or no reply from the OP label Oct 26, 2020
@stale stale bot closed this as completed Nov 9, 2020
@gbraad
Copy link
Contributor

gbraad commented Nov 9, 2020

@anjannath this is referenced by e2f2062. Anything still to be done?

@gbraad gbraad reopened this Nov 9, 2020
@stale stale bot removed the status/stale Issue went stale; did not receive attention or no reply from the OP label Nov 9, 2020
anjannath added a commit to anjannath/crc that referenced this issue Nov 10, 2020
@anjannath
Issue crc-org#1346 Remove CRC hyperkit machine files during cleanup
91f1de1 
First try to stop the crc related hyperkit process using pkill
then remove the files in ~/.crc/machines/crc
anjannath added a commit to anjannath/crc that referenced this issue Nov 10, 2020
@anjannath
Issue crc-org#1346 Remove CRC hyperkit machine directory during cleanup
287eabe 
First try to stop the crc related hyperkit process using pkill
then remove the files in ~/.crc/machines/crc
anjannath added a commit to anjannath/crc that referenced this issue Nov 10, 2020
@anjannath
Issue crc-org#1346 Remove CRC hyperkit machine files during cleanup
3fc4f90 
First try to stop the crc related hyperkit process using pkill
then remove the files in ~/.crc/machines/crc
anjannath added a commit to anjannath/crc that referenced this issue Nov 10, 2020
@anjannath
Issue crc-org#1346 Remove CRC hyperkit machine files during cleanup
6fcd342 
First try to stop the crc related hyperkit process using pkill
then remove the files in ~/.crc/machines/crc
@anjannath anjannath mentioned this issue Nov 10, 2020
Merged
anjannath added a commit to anjannath/crc that referenced this issue Nov 10, 2020
@anjannath
Issue crc-org#1346 Remove CRC hyperkit machine files during cleanup
372c2e0 
First try to stop the crc related hyperkit process using pkill
then remove the files in ~/.crc/machines/crc
anjannath added a commit to anjannath/crc that referenced this issue Nov 16, 2020
@anjannath
Issue crc-org#1346 Stop CRC related hyperkit process during cleanup
36a148a 
try to stop the crc hyperkit process using pkill on `crc cleanup`
anjannath added a commit to anjannath/crc that referenced this issue Nov 17, 2020
@anjannath
Issue crc-org#1346 Stop CRC related hyperkit process during cleanup
81dfa56 
try to stop the crc hyperkit process using pkill on `crc cleanup`
anjannath added a commit to anjannath/crc that referenced this issue Nov 17, 2020
@anjannath
Issue crc-org#1346 Stop CRC related hyperkit process during cleanup
df65839 
try to stop the crc hyperkit process using pkill on `crc cleanup`
anjannath added a commit to anjannath/crc that referenced this issue Nov 18, 2020
@anjannath
Issue crc-org#1346 Stop CRC related hyperkit process during cleanup
29d016f 
try to stop the crc hyperkit process using pkill on `crc cleanup`
anjannath added a commit to anjannath/crc that referenced this issue Nov 20, 2020
@anjannath
Issue crc-org#1346 Stop CRC related hyperkit process during cleanup
6cd222e 
try to stop the crc hyperkit process using pkill on `crc cleanup`
anjannath added a commit to anjannath/crc that referenced this issue Nov 20, 2020
@anjannath
Issue crc-org#1346 Stop CRC related hyperkit process during cleanup
8e19322 
try to stop the crc hyperkit process using pkill on `crc cleanup`
anjannath added a commit to anjannath/crc that referenced this issue Nov 26, 2020
@anjannath
Issue crc-org#1346 Stop CRC related hyperkit process during cleanup
5db00bf 
try to stop the crc hyperkit process using pkill on `crc cleanup`
cfergeau pushed a commit that referenced this issue Nov 26, 2020
@anjannath @cfergeau
Issue #1346 Stop CRC related hyperkit process during cleanup
1235723 
try to stop the crc hyperkit process using pkill on `crc cleanup`
@cfergeau
Copy link
Contributor

Ahh, just checked the removeCrcVM() for windows, and it manually deletes the vm without using the machine api, can we not use machine.Delete() from the cleanup function?

More than a year later, I'm wondering the same thing, why this ends up duplicating code preexisting in the machine drivers ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@praveenkumar praveenkumar

Labels
kind/task Workable task os/macos size/S
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove hyperkit machines directory during crc cleanup anjannath/crc
4 participants
@gbraad @praveenkumar @cfergeau @anjannath