Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Misleading error message with binaries without embedded bundle #432

Closed
cfergeau opened this issue Aug 20, 2019 · 0 comments
Closed

Misleading error message with binaries without embedded bundle #432

cfergeau opened this issue Aug 20, 2019 · 0 comments

Comments

@cfergeau
Copy link
Contributor

If you run crc start on a system which never ran crc, and if the crc binary
does not contain an embedded bundle, the error output is:

ERRO: Error occurred: File ....crc.bundle does not exist
ERRO: Error occurred: Run 'crc setup' to unpack the bundle to disk.

The 2nd line is incorrect as crc setup is never going to unpack anything in
this situation.
cfergeau added a commit to cfergeau/crc that referenced this issue Aug 28, 2019
@cfergeau
Issue crc-org#432: Improve some bundle-related error messages
37b9b04 
The main change is for "Run 'crc setup' to unpack the bundle to disk."
which is wrong when the bundle is not embedded in the binary. This also
slightly improve the wording of 2 other bundle-related messages.

This fixes crc-org#432
cfergeau added a commit to cfergeau/crc that referenced this issue Aug 29, 2019
@cfergeau
Issue crc-org#432: Improve some bundle-related error messages
9055e00 
The main change is for "Run 'crc setup' to unpack the bundle to disk."
which is wrong when the bundle is not embedded in the binary. This also
slightly improve the wording of 2 other bundle-related messages.

This fixes crc-org#432
cfergeau added a commit to cfergeau/crc that referenced this issue Aug 30, 2019
@cfergeau
Issue crc-org#432: Improve some bundle-related error messages
2060a06 
The main change is for "Run 'crc setup' to unpack the bundle to disk."
which is wrong when the bundle is not embedded in the binary. This also
slightly improve the wording of 2 other bundle-related messages.

This fixes crc-org#432
cfergeau added a commit to cfergeau/crc that referenced this issue Sep 2, 2019
@cfergeau
Issue crc-org#432: Improve some bundle-related error messages
2455535 
The main change is for "Run 'crc setup' to unpack the bundle to disk."
which is wrong when the bundle is not embedded in the binary. This also
slightly improve the wording of 2 other bundle-related messages.

This fixes crc-org#432
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@cfergeau