Module updates/addition of a vendor directory #82
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -1,3 +1,2 @@ | |||
| *.sw* | |||
| crc-driver-libvirt-* | |||
| vendor/ | |||
There was a problem hiding this comment.
Can we also have a make target to sync the vendor and have a check similar to what we have in crc to make sure it never become out of sync?
There was a problem hiding this comment.
I added make vendorcheck, I'm unconvinced about adding make vendor, as it's just calling go mod vendor
|
Can we have this crc-org/machine#54 merged before this one? |
Ah sure, it's merged now, so I'll update the branch in a bit. |
This removes most of the indirect go.mod dependencies.
The only untouched ones are the libvirt ones as this could cause machine-driver-libvirt to inadvertantly start linking with newer libvirt version depending on what is installed on the machine it's built on.
|
CI is unhappy, |
This aligns machine-driver-libvirt with what crc is doing.
the |
guillaumerose
approved these changes
Jan 21, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR takes advantage of the recent machine changes to remove most machine-driver-libvirt
dependencies, and adds a vendor/ directory.