Don't auto update Kotlin version + KSP #20
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds component selection rules, so that only the version specified in the toml file is accepted for the Kotlin version, it's never automatically updated as a result. As KSP requires a specific Kotlin version, any version that does not match the kotlin version is also rejected. To update both we can manually bump the Kotlin version in the toml file.
|
Thanks Hugo! 🙌 |
rock3r
approved these changes
Nov 22, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add component selection rules rejecting any Kotlin version that does not match the version in the
libs.version.tomlfile. The effect of this is that the Kotlin version will always require a manual version bump and will not be updated with./gradlew versionCatalogUpdate, which is probably the safest since Compose is also tied to a specific Kotlin version.For KSP any version that does not match the specified Kotlin version is rejected so that the KSP and Kotlin versions should always match.