Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: 3.14.27 is vulnerable to Broken Access Control #1329

Closed
kiyote33 opened this issue Jan 29, 2024 · 1 comment · Fixed by #1330
Closed

[Bug]: 3.14.27 is vulnerable to Broken Access Control #1329

kiyote33 opened this issue Jan 29, 2024 · 1 comment · Fixed by #1330
Assignees
Labels

Comments

@kiyote33
Copy link
Collaborator

kiyote33 commented Jan 29, 2024

Contact Details

devs@code4recovery.org

Website With Issue

https://patchstack.com/database/report-preview/68ad7d69-5e92-4fcc-9a30-62501b3b26b8?pin=FUIrb4IghDgUA6b0

What happened?

Technical details of recent vulnerability → Unfortunately our 3.14.27 patch didn't quite fix the problem referred to in the details. While a subscriber could not access the "Import & Export" page when logged in as a subscriber, they could and still can execute "https://code4recovery.org/wp-admin/admin-ajax.php?action=csv" from the address bar and download the meetings.csv file. The good news is that it's pretty easy to wrap the export code with some current_user_can () code. The 3.14.27 patch did get us off the Wordfence radar for now, but we will need to submit a patchlink to PastchStack so it doesn't get put out to the larger community in February...

What browsers are you seeing the problem on?

No response

Relevant log output/errors

The original report is available here: https://patchstack.com/database/report-preview/68ad7d69-5e92-4fcc-9a30-62501b3b26b8?pin=FUIrb4IghDgUA6b0

@kiyote33 kiyote33 added the bug label Jan 29, 2024
@joshreisner joshreisner self-assigned this Jan 29, 2024
@joshreisner
Copy link
Contributor

just a note: this is not really a bug. the intent of the CSV function is to be allowed to be used publicly, it's sort of the whole thing that started me on this journey back in 2013, our local website was terrible but they had a "download CSV" link i could use to make it better. the intent of keeping this a 'nopriv' ajax function was to enable sites to share their data if they chose to. i suppose that there are other ways to go about this though that don't look like a security oversight, so i can expedite a 'fix' to revoke this capability

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants