Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Buildings API endpoints with partial info #579

Merged
merged 1 commit into from Mar 3, 2021

Conversation

JustBeYou
Copy link
Contributor

@JustBeYou JustBeYou commented Mar 1, 2021

What does it fix?

Listing and searching buildings return only part of the details.
The client loads full info on request. (see BuildingDetailsFragment)

Closes #573

How has it been tested?

Added unit tests. Manual testing on the frontend, the screenshots below.
seismic1
Screenshot from 2021-03-01 13-00-28

@vercel
Copy link

vercel bot commented Mar 1, 2021

@JustBeYou is attempting to deploy a commit to the Code for Romania Team on Vercel.

A member of the Team first needs to authorize it.

@JustBeYou
Copy link
Contributor Author

Sorry for spamming with commits, but black is failing even if on my local machine everything is all right.

(‿ˠ‿) ❯ ❯) black --line-length 80 --target-version py37 --exclude migrations --check ./api
All done! ✨ 🍰 ✨
33 files would be left unchanged.

@tudoramariei
Copy link
Member

Make sure you have the right version of Black on your PC
Right now, it's testing with black==20.8b1

@JustBeYou
Copy link
Contributor Author

Thank you. Should be fine now.

@razvanpavel razvanpavel added api: Django The issue is in the Django codebase client: ReactJS labels Mar 3, 2021
@tudoramariei
Copy link
Member

@JustBeYou we merged some PRs and caused a few conflicts in your PR; we can merge the PR as soon as they're solved :)

This is a fix for issue code4romania#573. Listing and searching buildings return only part of the details.
The client loads full info on request. (see BuildingDetailsFragment)
@JustBeYou
Copy link
Contributor Author

@tudoramariei good to go 😃

@vercel
Copy link

vercel bot commented Mar 3, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/code4romania/seismic-risc/5S5NHns378PQBejo4fXT2TuSYmAN
✅ Preview: https://seismic-risc-git-fork-justbeyou-develop-code4romania.vercel.app

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: Django The issue is in the Django codebase client: ReactJS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create an API endpoint that returns partial info on buildings
3 participants