Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update shoulda and shoulda-matchers #462

Closed
2 tasks done
cbaudouinjr opened this issue Dec 15, 2020 · 0 comments · Fixed by #482
Closed
2 tasks done

Update shoulda and shoulda-matchers #462

cbaudouinjr opened this issue Dec 15, 2020 · 0 comments · Fixed by #482
Assignees
@cbaudouinjr
Labels
2.2 the next rodeo dependencies Pull requests that update a dependency file
Projects
v2.2.0
Milestone
v2.2.0

Comments

@cbaudouinjr
Copy link
Member

cbaudouinjr commented Dec 15, 2020 •
edited

Currently getting a BigDecimal.new deprecation warning in our tests, this is rooted in shoulda-matchers which depends on Shoulda. There are some possible breaking changes so just be sure to read the 4.0.0 release notes.

  • Update shoulda to 4.0.0
  • Update shoulda-matchers to 4.4.0
@cbaudouinjr cbaudouinjr added dependencies Pull requests that update a dependency file 2.2 the next rodeo labels Dec 15, 2020
@cbaudouinjr cbaudouinjr added this to the v2.2.0 milestone Dec 15, 2020
@cbaudouinjr cbaudouinjr added this to To do in v2.2.0 via automation Dec 15, 2020
@cbaudouinjr cbaudouinjr changed the title Update Shoulda to version 4.0.0 Update shoulda and shoulda-matchers Dec 15, 2020
@cbaudouinjr cbaudouinjr moved this from To do to In progress in v2.2.0 Dec 22, 2020
@cbaudouinjr cbaudouinjr mentioned this issue Dec 22, 2020
Merged
@cbaudouinjr cbaudouinjr linked a pull request Dec 22, 2020 that will close this issue
build(deps): Updates shoulda and shoulda-matchers #482
Merged
@cbaudouinjr cbaudouinjr moved this from In progress to Waiting for Review in v2.2.0 Dec 22, 2020
This was referenced Dec 22, 2020
Closed
Closed
@peterkos peterkos moved this from Waiting for Review to Review in progress in v2.2.0 Jan 17, 2021
v2.2.0 automation moved this from Review in progress to Done Jan 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cbaudouinjr cbaudouinjr

Labels
2.2 the next rodeo dependencies Pull requests that update a dependency file
Projects
No open projects
v2.2.0
  
Done
Milestone
v2.2.0
Development

Successfully merging a pull request may close this issue.

build(deps): Updates shoulda and shoulda-matchers codeRIT/hackathon-manager
1 participant
@cbaudouinjr