Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

set firebase to prod mode before deployment #343

Open
bxie opened this issue Jul 10, 2019 · 2 comments
Open

set firebase to prod mode before deployment #343

bxie opened this issue Jul 10, 2019 · 2 comments
Assignees
Labels
prod a task that we would only need to have for deployment to production (e.g. an optimization)
Projects

Comments

@bxie
Copy link
Collaborator

bxie commented Jul 10, 2019

To silence the firebase warnings in console. And probably for security?

Warning:

It looks like you're using the development build of the Firebase JS SDK.
When deploying Firebase apps to production, it is advisable to only import
the individual SDK components you intend to use.

For the module builds, these are available in the following manner
(replace with the name of a component - i.e. auth, database, etc):

CommonJS Modules:
const firebase = require('firebase/app');
require('firebase/');

ES Modules:
import firebase from 'firebase/app';
import 'firebase/';

Typescript:
import * as firebase from 'firebase/app';
import 'firebase/';

@bxie bxie added the prod a task that we would only need to have for deployment to production (e.g. an optimization) label Jul 10, 2019
@bxie bxie added this to the sprint 2: agency deployment milestone Jul 10, 2019
@bxie
Copy link
Collaborator Author

bxie commented Aug 3, 2019

this may be done automatically? don't see warnings on deployed version

@bxie
Copy link
Collaborator Author

bxie commented Aug 3, 2019

Firebase launch checklist doesn't mention this, so not necessary.

@bxie bxie closed this as completed Aug 3, 2019
@bxie bxie reopened this Aug 3, 2019
@bxie bxie self-assigned this Aug 3, 2019
@bxie bxie added this to Backlog in Agency Dev Aug 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
prod a task that we would only need to have for deployment to production (e.g. an optimization)
Projects
Agency Dev
  
Backlog
Development

No branches or pull requests

1 participant