Show tier page #31
Closed
Show tier page #31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 30 commits
February 19, 2016 23:47
…r into login-register-page
added 17 commits
March 25, 2016 01:37
|
Changes Unknown when pulling b367aa2 on alexyaoyang:show-tier-page into * on codebendercc:master*. |
| <h3>{{ tier.tierName|upper }} PLAN</h3> | ||
| </div> | ||
| <div class="panel-body text-center"> | ||
| <p class="lead" style="font-size:40px"><strong>${{ tier.price }} / month</strong></p> |
There was a problem hiding this comment.
This hardcoded dollar sign before the price will be difficult to change in the future if l20n is needed. Instead we could have used a twig currency filter that will make it a breeze to update the code in the future.
There was a problem hiding this comment.
@spiliot Installed twig extension and used twig currency filter in latest commit! Thanks!
Merged
|
Closing because of #39 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
@spiliot Only last two commits are new 597b8a5 & b367aa2. Thanks!