New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added a new headless Jbrowser driver #329

Merged
merged 4 commits into from May 12, 2016

Conversation

Projects
None yet
3 participants
@anilreddy
Contributor

anilreddy commented May 10, 2016

Hi,

This is a new headless driver JBrowser Driver which uses web-kit and doesn't need any additional browser dependencies.But is needs a minimum of Java 8 to run.

Thanks,
Anil

anilreddy added some commits May 10, 2016

added a new headless Jbrowser driver
Hi,

This is a new headless driver JBrowser Driver which uses web-kit and doesn't need any additional browser dependencies.But is needs a minimum of Java 8 to run.

Thanks,
Anil
@ddemin

This comment has been minimized.

Show comment
Hide comment
@ddemin

ddemin May 10, 2016

Contributor

@anilreddy, hi!
I think you should to include code with dependency adding and some tests in this PR

Contributor

ddemin commented May 10, 2016

@anilreddy, hi!
I think you should to include code with dependency adding and some tests in this PR

@anilreddy

This comment has been minimized.

Show comment
Hide comment
@anilreddy

anilreddy May 10, 2016

Contributor

@dimand58 Thank You

Contributor

anilreddy commented May 10, 2016

@dimand58 Thank You

@asolntsev asolntsev merged commit dc8170c into codeborne:master May 12, 2016

1 check failed

continuous-integration/travis-ci/pr The Travis CI build failed
Details
@asolntsev

This comment has been minimized.

Show comment
Hide comment
@asolntsev

asolntsev May 12, 2016

Member

@anilreddy Good, thank you for the pull request!
(I had to add few lines of code to WebDriverFactory to make it actually create JBrowserDriver instances.)

By the way, most of Selenide tests fail with JBrowserDriver. Is it really usable?

Member

asolntsev commented May 12, 2016

@anilreddy Good, thank you for the pull request!
(I had to add few lines of code to WebDriverFactory to make it actually create JBrowserDriver instances.)

By the way, most of Selenide tests fail with JBrowserDriver. Is it really usable?

asolntsev added a commit that referenced this pull request May 12, 2016

@anilreddy

This comment has been minimized.

Show comment
Hide comment
@anilreddy

anilreddy May 13, 2016

Contributor

@asolntsev Thanks for the info can you please copy all the failed testcases in gist page and add here so that i will open issue in the JBrowser driver page.

Contributor

anilreddy commented May 13, 2016

@asolntsev Thanks for the info can you please copy all the failed testcases in gist page and add here so that i will open issue in the JBrowser driver page.

@asolntsev

This comment has been minimized.

Show comment
Hide comment
@asolntsev

asolntsev May 13, 2016

Member

@anilreddy You just can execute ./gradle jbrowser in Selenide project.

Member

asolntsev commented May 13, 2016

@anilreddy You just can execute ./gradle jbrowser in Selenide project.

@anilreddy

This comment has been minimized.

Show comment
Hide comment
@anilreddy

anilreddy May 13, 2016

Contributor

@asolntsev I will do that..Thanks

Contributor

anilreddy commented May 13, 2016

@asolntsev I will do that..Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment