Skip to content

Commit

Permalink
Make Facebook/Twitter/Google handlers request over HTTPS
Browse files Browse the repository at this point in the history
 * This will make Firesheep requests of Facebook, Twitter, and Google encrypted, as to prevent the additional leaking of information.
 * Should also break how Firesheperd and Blacksheep currently detect Firesheep based on Facebook requests (though it's still certainly possible to detect and mess with it)
  • Loading branch information
Ian Gallagher committed Nov 18, 2010
1 parent ea1130b commit 9285c61
Show file tree
Hide file tree
Showing 3 changed files with 7 additions and 4 deletions.
5 changes: 3 additions & 2 deletions xpi/handlers/facebook.js
@@ -1,8 +1,9 @@
// Authors: // Authors:
// Eric Butler <eric@codebutler.com> // Eric Butler <eric@codebutler.com>
// Ian Gallagher <crash@neg9.org>
register({ register({
name: 'Facebook', name: 'Facebook',
url: 'http://www.facebook.com/home.php', url: 'https://www.facebook.com/home.php',
domains: [ 'facebook.com' ], domains: [ 'facebook.com' ],
sessionCookieNames: [ 'xs', 'c_user', 'sid' ], sessionCookieNames: [ 'xs', 'c_user', 'sid' ],


Expand All @@ -11,4 +12,4 @@ register({
this.userName = resp.body.querySelector('#navAccountName').innerHTML; this.userName = resp.body.querySelector('#navAccountName').innerHTML;
this.userAvatar = resp.body.querySelector('#navAccountPic img').src; this.userAvatar = resp.body.querySelector('#navAccountPic img').src;
} }
}); });
2 changes: 1 addition & 1 deletion xpi/handlers/google.js
Expand Up @@ -18,7 +18,7 @@ register({
// Grab avatar from Google Profiles page, if they have one // Grab avatar from Google Profiles page, if they have one
var avatar_element; var avatar_element;
try { try {
var profile = this.httpGet('http://www.google.com/profiles/me'); var profile = this.httpGet('https://www.google.com/profiles/me');
avatar_element = profile.body.querySelector('.ll_profilephoto.photo'); avatar_element = profile.body.querySelector('.ll_profilephoto.photo');
} }
catch(err) { catch(err) {
Expand Down
4 changes: 3 additions & 1 deletion xpi/handlers/twitter.js
@@ -1,9 +1,11 @@
// Authors: // Authors:
// Eric Butler <eric@codebutler.com> // Eric Butler <eric@codebutler.com>
// Ian Gallagher <crash@neg9.org>
Components.utils.import('resource://firesheep/util/RailsHelper.js'); Components.utils.import('resource://firesheep/util/RailsHelper.js');


register({ register({
name: 'Twitter', name: 'Twitter',
url: 'https://twitter.com/',
domains: [ 'twitter.com' ], domains: [ 'twitter.com' ],
sessionCookieNames: [ '_twitter_sess', 'auth_token' ], sessionCookieNames: [ '_twitter_sess', 'auth_token' ],


Expand Down Expand Up @@ -33,4 +35,4 @@ register({
this.userAvatar = resp.body.querySelector('#profile-image img').src; this.userAvatar = resp.body.querySelector('#profile-image img').src;
} }
} }
}); });

1 comment on commit 9285c61

@hrbrmstr
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Facebook changed session key name(s). Now "datr", "c_user", "lu", "sct"

Please sign in to comment.