Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suggestion: Add husky to catch test failures and lint errors locally #264

Closed
lukeecart opened this issue Sep 30, 2021 · 0 comments · Fixed by #265
Closed

Suggestion: Add husky to catch test failures and lint errors locally #264

lukeecart opened this issue Sep 30, 2021 · 0 comments · Fixed by #265

Comments

@lukeecart
Copy link
Contributor

lukeecart commented Sep 30, 2021

Husky is a package that can run git hooks before committing to a repository. This package could also be used to lint commit messages and run other bits of code as well.

Recently there have been a few issues with passing the lint and formating tests. The errors only show after the commit has been pushed and ran on Circle CI. Maybe it would be helpful to run tests, formatter, and lint just as contributors commit?

This can be version controlled because when a contributor runs yarn install this husky is initiated. Husky is used on a number of other open-source projects and I think Codecademy docs could benefit from also including it.

TLDR; Husky will catch errors locally before being run on Circle CI.

@sonnynomnom What do you think?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant