Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to Spring Cloud Brixton #167

Closed
Koizumi85 opened this issue Mar 10, 2016 · 9 comments
Closed

Update to Spring Cloud Brixton #167

Koizumi85 opened this issue Mar 10, 2016 · 9 comments

Comments

@Koizumi85
Copy link

Hello,

found, that the next version of spring-cloud-netflix (Brixton Release Train) will break spring-boot-admin.
Constructor of SimpleHostRoutingFilter changed from "public SimpleHostRoutingFilter(ProxyRequestHelper helper)" to "public SimpleHostRoutingFilter(ProxyRequestHelper helper, ZuulProperties properties)"

Stacktrace:

Caused by: org.springframework.beans.BeanInstantiationException: Failed to instantiate [org.springframework.cloud.netflix.zuul.filters.route.SimpleHostRoutingFilter]: Factory method 'simpleHostRoutingFilter' threw exception; nested exception is java.lang.NoSuchMethodError: org.springframework.cloud.netflix.zuul.filters.route.SimpleHostRoutingFilter.<init>(Lorg/springframework/cloud/netflix/zuul/filters/ProxyRequestHelper;)V
    at org.springframework.beans.factory.support.SimpleInstantiationStrategy.instantiate(SimpleInstantiationStrategy.java:189) ~[spring-beans-4.2.5.RELEASE.jar:4.2.5.RELEASE]
    at org.springframework.beans.factory.support.ConstructorResolver.instantiateUsingFactoryMethod(ConstructorResolver.java:588) ~[spring-beans-4.2.5.RELEASE.jar:4.2.5.RELEASE]
    ... 47 common frames omitted
Caused by: java.lang.NoSuchMethodError: org.springframework.cloud.netflix.zuul.filters.route.SimpleHostRoutingFilter.<init>(Lorg/springframework/cloud/netflix/zuul/filters/ProxyRequestHelper;)V
    at de.codecentric.boot.admin.config.RevereseZuulProxyConfiguration.simpleHostRoutingFilter(RevereseZuulProxyConfiguration.java:71) ~[spring-boot-admin-server-1.3.3-SNAPSHOT.jar:1.3.3-SNAPSHOT]
    at de.codecentric.boot.admin.config.RevereseZuulProxyConfiguration$$EnhancerBySpringCGLIB$$231adb08.CGLIB$simpleHostRoutingFilter$3(<generated>) ~[spring-boot-admin-server-1.3.3-SNAPSHOT.jar:1.3.3-SNAPSHOT]
    at de.codecentric.boot.admin.config.RevereseZuulProxyConfiguration$$EnhancerBySpringCGLIB$$231adb08$$FastClassBySpringCGLIB$$e4bebeba.invoke(<generated>) ~[spring-boot-admin-server-1.3.3-SNAPSHOT.jar:1.3.3-SNAPSHOT]
    at org.springframework.cglib.proxy.MethodProxy.invokeSuper(MethodProxy.java:228) ~[spring-core-4.2.5.RELEASE.jar:4.2.5.RELEASE]
    at org.springframework.context.annotation.ConfigurationClassEnhancer$BeanMethodInterceptor.intercept(ConfigurationClassEnhancer.java:355) ~[spring-context-4.2.5.RELEASE.jar:4.2.5.RELEASE]
    at de.codecentric.boot.admin.config.RevereseZuulProxyConfiguration$$EnhancerBySpringCGLIB$$231adb08.simpleHostRoutingFilter(<generated>) ~[spring-boot-admin-server-1.3.3-SNAPSHOT.jar:1.3.3-SNAPSHOT]
    at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) ~[na:1.8.0_72-internal]
    at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62) ~[na:1.8.0_72-internal]
    at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) ~[na:1.8.0_72-internal]
    at java.lang.reflect.Method.invoke(Method.java:498) ~[na:1.8.0_72-internal]
    at org.springframework.beans.factory.support.SimpleInstantiationStrategy.instantiate(SimpleInstantiationStrategy.java:162) ~[spring-beans-4.2.5.RELEASE.jar:4.2.5.RELEASE]
@Koizumi85 Koizumi85 changed the title spring-boot-admin breaks with Spring-Cloud BRIXTON spring-boot-admin breaks with Spring-Cloud BRIXTON (Snapshot-Builds) Mar 10, 2016
@joshiste
Copy link
Collaborator

I know. There are several changes needed for the Brixton update. I have a branch in my private repo for the Brixton update.
After the Brixton release (at the end of this quarter), I'll update the dependencies in boot admin.

@joshiste joshiste changed the title spring-boot-admin breaks with Spring-Cloud BRIXTON (Snapshot-Builds) Update to Spring Cloud Brixton Mar 10, 2016
@royremi
Copy link

royremi commented Apr 12, 2016

Hi Johannes, do you plan to release for brixton RC1? Waiting on that. Will be really useful!

Thanks

@joshiste
Copy link
Collaborator

No.
I plan to release after the Brixton Release. We can't publish on RC1 since it's not in maven central and all our dependencies need to be in maven central to publish there.

@joshlong
Copy link
Contributor

would u be willing to publish a milestone or snapshot version so that we could link to it in updated code, in the meantime?

@joshiste
Copy link
Collaborator

joshiste commented Apr 27, 2016

I've committed the changes to master. When the travis build has passed, snapshots are available in the sonatype snapshot repo:

<repositories>
        <repository>
             <id>sonatype-nexus-snapshots</id>
            <snapshots>
                <enabled>true</enabled>
            </snapshots>
            <url>https://oss.sonatype.org/content/repositories/snapshots/</url>
        </repository>
</repositories>

closed with 272633e

@joshiste
Copy link
Collaborator

@joshlong the snapshot build is now available. I appreciate some feedback 😄

@tjuchniewicz
Copy link

Snapshot works fine for me.

When can we expect release of 1.3.3? Brixton.RELEASE is available now.

@joshiste
Copy link
Collaborator

joshiste commented May 11, 2016

Brixton.RELEASE is available now.

not yet pushed to repo1.maven.org.

We have to wait for that. I update the master branch after spring cloud is published to maven central and provide a snapshot build for testing. One week after I make the release.

@joshiste
Copy link
Collaborator

snapshots are built. happy testing! 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants