Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Return value must be of type Codeception\Task\Splitter\TestFileSplitterTask" when splitting the tests after upgrading to version 1.0 #62

Closed
ccsuperstar opened this issue Jul 21, 2021 · 10 comments
Labels

Comments

@ccsuperstar
Copy link
Contributor

After updating the robo-paracept version, and making the changes indicated in the readme, I get this error when I run the split command
PHP Fatal error: Uncaught TypeError: RoboFile::taskSplitTestFilesByGroups(): Return value must be of type Codeception\Task\Splitter\TestFileSplitterTask, Robo\Collection\CollectionBuilder returned in /vendor/codeception/robo-paracept/src/Splitter/TestsSplitterTrait.php:26

@DavertMik
Copy link
Member

@vansari could you help with this?

@DavertMik DavertMik added the bug label Jul 22, 2021
@vansari
Copy link
Collaborator

vansari commented Jul 22, 2021

Yes of course. I will do it tomorrow evening. @DavertMik

@vansari
Copy link
Collaborator

vansari commented Jul 22, 2021

Hi @ccsuperstar

can you please check the fix?
I think the return type was not correct :-)

I forgot to use the union type

@ccsuperstar
Copy link
Contributor Author

It's ok now on splitting tests, thanks!

@ccsuperstar
Copy link
Contributor Author

ccsuperstar commented Jul 23, 2021

Could you tell me how to use the GroupFilter for tests failed?

@vansari
Copy link
Collaborator

vansari commented Jul 23, 2021

Hi @ccsuperstar

Could you please open a new issue for this question? I think this would be a new feature.

Please let us know what you want to do.

Bye 👋

@ccsuperstar
Copy link
Contributor Author

Ok I'll do it!

@ccsuperstar
Copy link
Contributor Author

I can make a PR with my previous code if you want

@vansari
Copy link
Collaborator

vansari commented Aug 3, 2021

Hi @ccsuperstar

I think this issue can be closed?!

@ccsuperstar
Copy link
Contributor Author

Yes!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants