New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Playwright] I.amOnPage implementation prevents navigating to about:blank #2311

Closed

guillaume86 opened this issue Apr 2, 2020 · 1 comment · Fixed by #3470

Assignees

Labels

bug good first issue playwright

guillaume86 commented Apr 2, 2020

This regex test prevents navigating to about:blank

https://github.com/Codeception/CodeceptJS/blob/fb2ca3002978d4b803230709cd356b0265ed930b/lib/helper/Playwright.js#L612-L614

This behavior do not match the documentation (https://codecept.io/helpers/Playwright/#amonpage) that states that only URLs starting with / will use the config base URL.

DavertMik added bug playwright good first issue labels

Contributor

zaxoavoki commented Oct 19, 2022

@DavertMik I would like to fix it, could you assign it to me, please?

kobenguyent assigned zaxoavoki

zaxoavoki mentioned this issue

Changed regex for url for amOnPage func #3470

Merged

16 tasks

DavertMik closed this as completed in #3470

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment