New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move semver to prod dependencies #3413
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
褋褋 @DavertMik
Any chance of a review? of this and codeceptjs/configure#32 Much appreciated, thanks! |
Thanks for catching this! |
Would it be possible to get a release @DavertMik? Thanks for the merge! |
Yes, i was planning to do it today |
hey @DavertMik if you get a chance a release would be appreciated, thanks :) |
@timja I am really sorry I fucked up my promises 馃槶 |
No worries at all, I understand, just when you have time, much appreciated 馃槃 |
Motivation/Description of the PR
On a yarn 3 installation which uses PnP I was not able to use CodeceptJs because it complains that semver is trying to be used but it's not listed in dependencies, it is in devDependencies but it does seem to be used in some places outside of the tests so I think it's correct to move it to dependencies.
error:
usage location:
Applicable helpers:
Applicable plugins:
Type of change
Checklist:
[ ] Tests have been added[ ] Documentation has been added (Runnpm run docs
)npm run lint
)I wasn't able to run the git hooks or even
npm install
on my machine in this repository, looking at CI it uses node 12.8.0 which doesn't even run on my architecture (arm64).npm test
)again
npm install
fails