Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed creating of JavaScript test using "codeceptjs gt" #3611

Merged
merged 1 commit into from May 28, 2023
Merged

Fixed creating of JavaScript test using "codeceptjs gt" #3611

merged 1 commit into from May 28, 2023

Conversation

mirao
Copy link
Contributor

@mirao mirao commented Mar 6, 2023

Motivation/Description of the PR

Applicable helpers:

  • WebDriver
  • Puppeteer
  • Nightmare
  • REST
  • FileHelper
  • Appium
  • Protractor
  • TestCafe
  • Playwright

Applicable plugins:

  • allure
  • autoDelay
  • autoLogin
  • customLocator
  • pauseOnFail
  • coverage
  • retryFailedStep
  • screenshotOnFail
  • selenoid
  • stepByStepReport
  • stepTimeout
  • wdio
  • subtitles

Type of change

  • 馃敟 Breaking changes
  • 馃殌 New functionality
  • 馃悰 Bug fix
  • 馃搵 Documentation changes/updates
  • 鈾笍 Hot fix
  • 馃敤 Markdown files fix - not related to source code
  • 馃拝 Polish code

Checklist:

  • Tests have been added
  • Documentation has been added (Run npm run docs)
  • Lint checking (Run npm run lint)
  • Local tests are passed (Run npm test)

@Arhell Arhell requested a review from DavertMik March 7, 2023 00:08
@zhigulin-n zhigulin-n mentioned this pull request Mar 28, 2023
Closed
33 tasks
@DavertMik
Copy link
Contributor

Thank you, it is good to be merged!

@DavertMik DavertMik merged commit f7d01e2 into codeceptjs:3.x May 28, 2023
2 of 7 checks passed
@mirao
Copy link
Contributor Author

mirao commented Aug 4, 2023

If this PR is accepted I'm going to create a PR for codeceptjs-chai to fix the specific issue mentioned in #3514 (comment)

It's not needed since SitamJana/codeceptjs-chai#39

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Arhell Arhell Arhell approved these changes

@DavertMik DavertMik Awaiting requested review from DavertMik

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@mirao @DavertMik @Arhell