Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(pw): some improvements for recording network steps #3771

Merged
merged 5 commits into from Aug 20, 2023
Merged

fix(pw): some improvements for recording network steps #3771

merged 5 commits into from Aug 20, 2023

Conversation

kobenguyent
Copy link
Collaborator

@kobenguyent kobenguyent commented Jul 21, 2023 •
edited

Motivation/Description of the PR

  • Remove redundant async/await
  • Parse the responses thanks to Roy Collings

Applicable helpers:

  • Playwright

Type of change

  • 馃拝 Polish code

Checklist:

  • Tests have been added
  • Documentation has been added (Run npm run docs)
  • Lint checking (Run npm run lint)
  • Local tests are passed (Run npm test)

@ngraf
Copy link
Contributor

ngraf commented Jul 24, 2023 •
edited

I agree with @kobenguyent . The async/awaits are not needed for those methods modified in the PR:

  • I.startRecordingTraffic
  • I.blockTraffic
  • I.mockTraffic

@kobenguyent kobenguyent changed the title fix(pw): remove unneeded async/await fix(pw): some improvements for recording network steps Jul 25, 2023
@DavertMik
Copy link
Contributor

Thanks!

@DavertMik DavertMik merged commit 008c9fc into 3.x Aug 20, 2023
7 of 9 checks passed
@DavertMik DavertMik deleted the fix-recording-network branch August 20, 2023 09:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DavertMik DavertMik DavertMik approved these changes

@roycollings roycollings roycollings approved these changes

@Arhell Arhell Arhell approved these changes

Assignees
No one assigned
Labels
enhancement playwright
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@kobenguyent @ngraf @DavertMik @roycollings @Arhell