Fix enable highlight element #3778
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@philkas may you also fix for https://github.com/codeceptjs/CodeceptJS/blob/3.x/lib/helper/WebDriver.js#L2917 as webdriver also provides this feat? |
|
@kobenguyent oh yes for sure, I can do it. |
|
@kobenguyent done |
Nice, thank you @philkas |
Arhell
approved these changes
Jul 26, 2023
|
Thank you! Looks good 馃憤 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation/Description of the PR
The 'highlightElement' option (described in the helper docs) was not correctly checked in the code, so that this option had no effect. Furthermore no default value was defined. So this fix sets the option per default to false
Applicable helpers:
Applicable plugins:
Type of change
Checklist:
npm run docs)npm run lint) (too many errors not from my side)npm test)