Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: move to waitFor #3933

Merged
merged 2 commits into from Oct 21, 2023
Merged

fix: move to waitFor #3933

merged 2 commits into from Oct 21, 2023

Conversation

kobenguyent
Copy link
Collaborator

Motivation/Description of the PR

Applicable helpers:

  • Playwright

Checklist:

  • Tests have been added
  • Documentation has been added (Run npm run docs)
  • Lint checking (Run npm run lint)
  • Local tests are passed (Run npm test)

@kobenguyent kobenguyent linked an issue Oct 17, 2023 that may be closed by this pull request
Moving from waitForSelector to waitFor #3925
Closed
@Arhell Arhell requested a review from DavertMik October 21, 2023 09:08
@kobenguyent kobenguyent merged commit f598059 into 3.x Oct 21, 2023
9 checks passed
@kobenguyent kobenguyent deleted the 3925-moving-from-waitforselector-to-waitfor branch October 21, 2023 11:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Arhell Arhell Arhell approved these changes

@DavertMik DavertMik Awaiting requested review from DavertMik

Assignees
No one assigned
Labels
playwright
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Moving from waitForSelector to waitFor
2 participants
@kobenguyent @Arhell