Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: proceedSee #3939

Merged
merged 2 commits into from Oct 21, 2023
Merged

fix: proceedSee #3939

merged 2 commits into from Oct 21, 2023

Conversation

kobenguyent
Copy link
Collaborator

@kobenguyent kobenguyent commented Oct 19, 2023

Motivation/Description of the PR

Scenario.only('within', async ({I}) => {
    I.amOnPage('http://127.0.0.1:8000/iframe');
    within({xpath: "//h1"}, () => {
        I.see("Iframe test");
    });
})
  • Fix error
       within:
     locator.innerText: Timeout 5000ms exceeded.
=========================== logs ===========================
waiting for locator('xpath=//h1').first().locator('body')
============================================================
      at Playwright.proceedSee (node_modules/codeceptjs/lib/helper/Playwright.js:3411:41)

Applicable helpers:

  • Playwright

Type of change

  • 馃悰 Bug fix

Checklist:

  • Tests have been added
  • Documentation has been added (Run npm run docs)
  • Lint checking (Run npm run lint)
  • Local tests are passed (Run npm test)

@kobenguyent kobenguyent merged commit 80e4351 into 3.x Oct 21, 2023
9 checks passed
@kobenguyent kobenguyent deleted the fix-proceed-see branch October 21, 2023 05:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants