Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix timeout behavior of getParcelInvoice/getTransactionInvoice #55

Closed
joojis opened this issue Jul 6, 2018 · 1 comment
Closed

Fix timeout behavior of getParcelInvoice/getTransactionInvoice #55

joojis opened this issue Jul 6, 2018 · 1 comment
Labels
bug Something isn't working rpc

Comments

@joojis
Copy link
Contributor

joojis commented Jul 6, 2018 •
edited
Loading

getParcelInvoice/getTransactionInvoice send a RPC request repeatedly until timeout.

But, currently, the request is not aborted. So if the request takes 10 seconds when given timeout is 5 seconds, the method takes 10 seconds. It should be aborted at the moment of the timeout.

I think sendRpcRequest should support a timeout option.
https://github.com/tedeh/jayson#client-interface-description
@joojis joojis added bug Something isn't working rpc labels Jul 6, 2018
@joojis
Copy link
Contributor Author

joojis commented Apr 2, 2019

It's outdated.

@joojis joojis closed this as completed Apr 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working rpc
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@joojis