Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fee-monitor] dynamicChecker should be atomic #121

Closed
HoOngEe opened this issue Sep 11, 2019 · 0 comments · Fixed by #148
Closed

[fee-monitor] dynamicChecker should be atomic #121

HoOngEe opened this issue Sep 11, 2019 · 0 comments · Fixed by #148
Assignees
Labels
bug Something isn't working

Comments

@HoOngEe
Copy link
Contributor

HoOngEe commented Sep 11, 2019

dynamicChecker class uses internal states. If a connection error occurs in the middle of fee distribution checking routine, retry logic re-call the function checkBlock with the parameter dynamicChecker which has partially updated state. That may leads to an block error and a term error.

@HoOngEe HoOngEe changed the title dynamicChecker should be atomic [fee-monitor] dynamicChecker should be atomic Sep 11, 2019
@remagpie remagpie added the bug Something isn't working label Sep 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants