Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"codeclimate init && codeclimate validate-config" generates an unexpected key #13

Closed
kevinburkeshyp opened this issue Jun 20, 2015 · 5 comments

Comments

@kevinburkeshyp
Copy link

"codeclimate init" on a JS-heavy project generated

---
engines:
  coffeelint:
    enabled: true
  eslint:
    enabled: true
  csslint:
    enabled: true
ratings:
  paths:
  - "**.coffee"
  - "**.js"
  - "**.jsx"
  - "**.css"

I then ran codeclimate validate-config and was told:

WARNING: unexpected key "ratings", dropping

I am running version 0.0.1.

@pbrisbin
Copy link
Contributor

Hi @kevinburkeshyp , sorry about this. I'm not exactly sure why that's happening, but you can ignore the warning for now. I'll create a card in our internal Trello to figure this out.

@ABaldwinHunter
Copy link
Contributor

Hi @kevinburkeshyp. I am looking into this issue and having some trouble replicating it. The codeclimate.yml you have above looks good to me.

I think you might need to upgrade your version of codeclimate. I'm running 0.0.6.

Try brew upgrade codeclimate to update if you're using brew. Otherwise, you can also try docker pull codeclimate/codeclimate to pull the most recent image.

Let me know how that goes!

@gdiggs
Copy link
Contributor

gdiggs commented Jul 1, 2015

@kevinburkeshyp Can you confirm whether or not this is fixed for you? I can't repro it anymore either.

@ntwb
Copy link

ntwb commented Jul 24, 2015

Just taking codeclimate for a spin and needed to validate my config and happened upon this issue.

Using codeclimate 0.1.3 on a heavily focused PHP/JS project:

codeclimate init
codeclimate validate-config
Result: No errors or warnings found in .codeclimate.yml file.

@pbrisbin
Copy link
Contributor

I think it sounds like we're good here? Thanks for confirming @ntwb

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants