Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AC-52] Server-Side Request Forgery (SSRF) in Remote Macro + Forge-Fetch-Client #52

Closed
clouless opened this issue Feb 27, 2024 · 1 comment
Labels
Milestone

Comments

@clouless
Copy link
Member

clouless commented Feb 27, 2024

Bug

Server-Side Request Forgery (SSRF) in Remote Macro + Forge-Fetch-Client.
A user can query http://localhost and http://127.0.0.1 and could potentially fetch data from internal hostnames/services.

Acceptance Criteria

  • 🟠 This should be globally fixed by Atlassian in the Forge fetch Client! But for now we do:
  • ✅ only allow https:// and http://, block all other protocols
  • ✅ block http[s]://127.0.0.1* (ipv4)
  • ✅ block http[s]://localhost* (ipv4+6)
  • ✅ block http[s]://[::1]* (ipv6)
  • ✅ disable follow redirects
  • ✅ block internal Atlassian IPs: 172.16.0.0/16, 10.0.0.0/8, 169.254.169.254
  • ✅ implement DNS resolver to block any hostnames pointing to localhost (ipv4+ipv6)

Notes

Error Messages displayed like this:

1️⃣ Disallowed redirect

image

2️⃣ Blocklisted IP or Domain

image
@clouless clouless added the bug label Feb 27, 2024
@clouless clouless added this to the cloud milestone Feb 27, 2024
@clouless clouless changed the title Server-Side Request Forgery (SSRF) in Remote Macro + Forge-Fetch-Client [AC-52] Server-Side Request Forgery (SSRF) in Remote Macro + Forge-Fetch-Client Feb 27, 2024
@clouless
Copy link
Member Author

Released to the Atlassian Marketplace today

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant