my palindrome solution in go #46
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
drkennetz
requested review from
birenderjit,
ericwburden,
parhaml and
xanderyzwich
birenderjit
reviewed
Apr 20, 2021
parhaml
approved these changes
Apr 20, 2021
| return false | ||
| } | ||
| // 256 chars in ascii charset | ||
| ords := make([]int, 256) |
There was a problem hiding this comment.
Fun idea to pre-make the map
| if ords[i]%2 != 0 { | ||
| oddCount++ | ||
| } | ||
| if oddCount > 1 { |
There was a problem hiding this comment.
nice to interrupt as early as possible 💯
Comment on lines
+9
to
+26
| tables := []struct { | ||
| x interface{} | ||
| y bool | ||
| }{ | ||
| {"carrace", true}, | ||
| {"", false}, | ||
| {"annnab", false}, | ||
| {41231234, true}, | ||
| } | ||
|
|
||
| for _, table := range tables { | ||
| result := CanMakePalindrome(table.x) | ||
| if result != table.y { | ||
| t.Error("FAIL: CanMakePalindrome of: ", result, "was incorrect, got: ", result, "expected: ", table.y) | ||
| } else { | ||
| fmt.Println("SUCCESS: CanMakePalindrome of: ", result, "was correct, got: ", result, "expected: ", table.y) | ||
| } | ||
| } |
If they are converted to string then ranging over them should return each character’s ascii value. Numbers have an ascii encoding also in the 256 charset so it should work. I am incrementing the index in the int slice of 0s that corresponds to the ascii encoding. I’ll add it to the test table tomorrow to make sure, but I don’t see why it wouldn’t work. |
ericwburden
approved these changes
Apr 21, 2021
|
@birenderjit just to follow up, I added that test case to the table and it passed. |
|
Nice!!
… On Apr 21, 2021, at 9:14 AM, Dennis R Kennetz ***@***.***> wrote:
@birenderjit <https://github.com/birenderjit> just to follow up, I added that test case to the table and it passed.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub <#46 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAF6UGKZQBGOIAO2D374MYDTJ3MVVANCNFSM43JESKDQ>.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
can be run in this directory by running
go test. I've only handled the types of int and string in my type conversions (but I had a fun time writing a type converter). I also got my hands a little dirty with writing test tables!