Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add all the bash params #193

Merged
merged 24 commits into from
Jan 4, 2021
Merged

Add all the bash params #193

merged 24 commits into from
Jan 4, 2021

Conversation

thomasrockhu
Copy link
Contributor

@thomasrockhu thomasrockhu commented Jan 2, 2021

  1. Adds all the bash parameters
  2. Splits out build parameters from the uploading
  3. Moves test coverage to a demo folder
  4. Adds eslint
  5. Collects coverage on the build parameter file

fixes #92
fixes #73
fixes #186

@codecov
Copy link

codecov bot commented Jan 2, 2021

Codecov Report

Merging #193 (8d13d6a) into master (5b42a30) will increase coverage by 10.17%.
The diff coverage is 99.12%.

Impacted file tree graph

@@             Coverage Diff             @@
##           master     #193       +/-   ##
===========================================
+ Coverage   87.50%   97.67%   +10.17%     
===========================================
  Files           2        3        +1     
  Lines          16      129      +113     
  Branches        2       38       +36     
===========================================
+ Hits           14      126      +112     
- Misses          2        3        +1     
Flag Coverage Δ
demo 87.50% <100.00%> (?)
script 99.11% <99.11%> (?)
unittest ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
demo/calculator/calculator.ts 100.00% <ø> (ø)
src/buildExec.ts 99.11% <99.11%> (ø)
demo/coverage-test/coverage.ts 80.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5b42a30...8d13d6a. Read the comment docs.

@thomasrockhu thomasrockhu marked this pull request as ready for review January 2, 2021 23:53
@thomasrockhu thomasrockhu requested a review from a team January 2, 2021 23:54
Copy link
Contributor

@drazisil-codecov drazisil-codecov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good. Since it passes tests I'll say it's good. Anything breaking here that would justify a major version bump?

This was referenced Mar 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants