Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: how to use multiple flags #50

Closed
blueyed opened this issue Jan 23, 2020 · 4 comments
Closed

doc: how to use multiple flags #50

blueyed opened this issue Jan 23, 2020 · 4 comments

Comments

@blueyed
Copy link

blueyed commented Jan 23, 2020

The README/doc should have an example how to use multiple flags.
(I've guessed them to be a string separated by "," (commata), as with the codecov-bash uploader itself, but it would be good to clarify)

@blueyed
Copy link
Author

blueyed commented Jan 24, 2020

description: 'Flag upload to group coverage metrics (e.g. unittests | integration | ui,chrome)'
has examples.

@ibrahim0814
Copy link
Contributor

Good point! I've added instructions for how to specify multiple flags in this commit

@deepankarb
Copy link

It's still not clear how multiple flags will get associated with multiple reports. E.g.:

- name: Code coverage (via codecov.io)
      if: matrix.api-level == 29 # Only upload coverage from API 29
      uses: codecov/codecov-action@v2
      with:
        files: engine/build/reports/coverage/debug/report.xml, datacapture/build/reports/coverage/debug/report.xml, datacapturegallery/build/reports/coverage/debug/report.xml
        flags: engine, datacapture, datacapturegallery
        fail_ci_if_error: true
        verbose: true

Generates the following:

/Users/runner/work/_actions/codecov/codecov-action/v2/dist/codecov -n  -Q github-action-2.1.0 -Z -f engine/build/reports/coverage/debug/report.xml -f  datacapture/build/reports/coverage/debug/report.xml -f  datacapturegallery/build/reports/coverage/debug/report.xml -F engine -F  datacapture -F  datacapturegallery -C <redacted> -v

I don't think this is correct.

There should be a way to configure a monorepo with multiple projects / modules, one for each flag.

@deepankarb
Copy link

deepankarb commented Sep 21, 2021

To clarify, I have the coverage reports generated for each module in a single step. There should be a way to pick each report and associate with a flag each.

Currently is seems it is only possible via hacks like this: https://stackoverflow.com/questions/66561281/optimal-usage-of-codecov-in-a-monorepo-context-with-separate-flags-for-each-pack

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants