Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Different data results from PR comment to app #1321

Closed
codecovdesign opened this issue Feb 29, 2024 · 2 comments
Closed

Different data results from PR comment to app #1321

codecovdesign opened this issue Feb 29, 2024 · 2 comments
Assignees
Labels
bug Something isn't working in discovery The design, product, and specifications require refinement

Comments

@codecovdesign
Copy link
Contributor

codecovdesign commented Feb 29, 2024

Describe the bug
Report of different data shown on PR comment and app, see here: codecov/feedback#8 (comment)

  • patch reporting as 92.80303% in PR report and 95.83% in-app
  • missing lines is 19 in pr report and 5 in-app (changed lines)

Screenshot 2024-02-29 at 8 29 01 AM
Screenshot 2024-02-29 at 8 29 08 AM

Related PR

Expected behavior
Consistent data display of project, patch, and lines missin

@giovanni-guidini
Copy link

Looks like the numbers stabilized afterwards...

Image

Image

The customer in question also mentioned this:

The above library that I linked is sending multiple coverage files since some of the tests run on different workers in parallel.
Codecov will create a coverage comment when the first file al finishes processing, so I get a mail notifying me with wrong coverage. In most cases this coverage comment will be updated although I've seen cases where it didn't.
I would consider posting the coverage comment only when all the runners complete.

It is very likely that we simply failed to send one of the notifications so the PR comment didn't update to the value displayed in the UI. As more commits were added to the PR new notifications were issues and both reports were brought to parity.

@codecov-hooky codecov-hooky bot closed this as completed Mar 21, 2024
@codecovdesign codecovdesign added in discovery The design, product, and specifications require refinement and removed bug Something isn't working labels Mar 21, 2024
@codecov-hooky codecov-hooky bot added bug Something isn't working labels Mar 21, 2024
@codecovdesign
Copy link
Contributor Author

@giovanni-guidini per slack removing the bug label and adding in discovery

@codecovdesign codecovdesign reopened this Mar 21, 2024
@codecov-hooky codecov-hooky bot closed this as completed Mar 21, 2024
@codecov-hooky codecov-hooky bot closed this as completed Mar 21, 2024
@codecovdesign codecovdesign reopened this Mar 21, 2024
@codecov-hooky codecov-hooky bot closed this as completed Mar 21, 2024
@codecovdesign codecovdesign reopened this Mar 21, 2024
@giovanni-guidini giovanni-guidini removed the bug Something isn't working label Mar 22, 2024
@codecov-hooky codecov-hooky bot added the bug Something isn't working label Mar 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working in discovery The design, product, and specifications require refinement
Projects
None yet
Development

No branches or pull requests

2 participants