Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Codecov changes master or main coverage on PRs from forks #139

Closed
MarvinJWendt opened this issue Jun 3, 2021 · 5 comments
Closed

Codecov changes master or main coverage on PRs from forks #139

MarvinJWendt opened this issue Jun 3, 2021 · 5 comments
Assignees
Labels
Bug For issues and unexpected behaviors

Comments

@MarvinJWendt
Copy link

Hi, I am using this action on my project pterm/pterm and today we got a PR that somehow changed my overall coverage for the master branch, even that I haven't merged it into master. I could reproduce that in this PR that I made: pterm/pterm#218 which reduces the Coverage from 100% to 98% even tho I haven't merged it.

It also detects that the PR commits are in master, which they aren't
image

This never happened before, and now someone could easily manipulate my coverage down to 0%.

@ethanwharris
Copy link

+1 We are also seeing this issue. A lot of first-time contributor PRs come from master branches so coverage drops can be quite frequent for some projects.

@thomasrockhu thomasrockhu self-assigned this Jul 28, 2021
@thomasrockhu-codecov thomasrockhu-codecov added the Bug For issues and unexpected behaviors label Mar 23, 2023
@thomasrockhu-codecov
Copy link
Contributor

Tracking internally as 3043

@thomasrockhu-codecov thomasrockhu-codecov transferred this issue from codecov/codecov-action Nov 7, 2023
@thomasrockhu-codecov thomasrockhu-codecov changed the title Bug: Codecov changes "master" coverage on PRs that aren't merged. Codecov changes master or main coverage on PRs from forks Nov 7, 2023
@thomasrockhu-codecov thomasrockhu-codecov removed their assignment Nov 9, 2023
@eliatcodecov
Copy link
Contributor

This underlying bug is fixed for the Codecov CLI (see: codecov/engineering-team#661). this work is not in the node uploader. We will be moving the codecov github action to use the CLI instead of the node uploader soon (see: codecov/engineering-team#813). Once this is done, this problem be resolved for customers using the github action.

@rohan-at-sentry
Copy link

Hi everyone

We've released a new version of the codecov action and CLI that should help address the issue you're seeing here. Here's a link to our blog outlining the latest update including how to upgrade to the CLI. You can also visit our docs for more detailed information on how to get set up with the CLI, especially if you're not using our Github Action, Bitrise Step or CircleCI orb.

@thomasrockhu-codecov
Copy link
Contributor

Closing for now. If the CLI is not fixing the issue, feel free to comment to reopen

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug For issues and unexpected behaviors
Projects
Status: Waiting for: Product Owner
Development

No branches or pull requests

6 participants