GitHub Codecov v1 action freezes jobs when uploading report

[sbidoul]

Describe the bug

I'm contacting you on behalf of the Odoo Community Association.

Since this morning, all our CI jobs are stuck in codecov/codecov-action@v1 step

A typical stuck job log looks like this:

Environment (please complete the following information):

GitHub actions

Expected behavior

codecov-actions steps should fail or succeed but not remain pending "forever".

[thomasrockhu-codecov]

@sbidoul can you try using v3 or v4? The v1 version has been deprecated for some time.

[sbidoul]

@thomasrockhu-codecov Yes, we are migrating to v4, this solves the issue.

However it would be nice if v1 would just fail instead of blocking, as this quickly fills the runners queue, and ends up blocking our whole GitHub org.

[thomasrockhu-codecov]

@sbidoul yeah I understand that. v1 SHOULD work still, but I know those endpoints haven't been used in ages. I'm going to close this out for now, but let me know if you struggle with migrating to v4.

[sbidoul]

@thomasrockhu-codecov The problem is not that v1 does not work any more. If it would simply fail, that would be totally fine and people would notice quickly that they need to upgrade. The problem is that it blocks, leading to very long actions queues congestion. That is not a friendly way to sunset a endpoint used from GitHub actions.

[thomasrockhu-codecov]

@sbidoul hmm, I just ran v1 on a branch to see and it didn't block out. Is this happening all the time or just sometimes?

To just manage expectations, if this is a problem specific to action/v1 we will not be patching it, but I want to make sure that this is a problem with upload/v4 endpoint first.

[thomasrockhu-codecov]

@sbidoul ok, I did some digging and I think I found the issue on our side. If you want to continue using v1, I strongly suggest adding a token to upload. However, we will work to make a fix for this.

[sbidoul]

@sbidoul ok, I did some digging and I think I found the issue on our side. If you want to continue using v1, I strongly suggest adding a token to upload. However, we will work to make a fix for this.

Thanks a lot for investigating @thomasrockhu-codecov

To be clear we are migrating to v4 (with which we have no issues, just to confirm), but we have a long tail of v1 on older branches and open PRs.

I just ran v1 on a branch to see and it didn't block out. Is this happening all the time or just sometimes?

Hard to tell for sure, but it is very prevalent.