Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI script example in README is outdated/wrong? #23

Closed
smheidrich opened this issue May 22, 2022 · 2 comments · Fixed by #32
Closed

CI script example in README is outdated/wrong? #23

smheidrich opened this issue May 22, 2022 · 2 comments · Fixed by #32
Assignees

Comments

@smheidrich
Copy link

The README says:

Inside .github/workflows/python-standard.yml file:

install:
 - pip install codecov
 - pip install pytest-cov
script:
 - pytest --cov=./ --cov-report=xml
 - codecov

Is it just me or is that not proper GitHub Actions syntax? script followed by a list of instructions looks more like GitLab CI syntax, but that doesn't have install either. Or is it supposed to be some kind of CI spec pseudocode?

@cclauss
Copy link
Contributor

cclauss commented Mar 11, 2023

@thomasrockhu-codecov Your thoughts please on this issue?

@thomasrockhu-codecov thomasrockhu-codecov self-assigned this Mar 11, 2023
@thomasrockhu-codecov
Copy link
Contributor

@cclauss this is definitely outdated, I'll make a fix next week. Thanks for pinging, and thanks for the issue @smheidrich

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants