Skip to content
This repository has been archived by the owner on Oct 24, 2023. It is now read-only.

Coverage overlay for PRs #23

Closed
jarekwg opened this issue Mar 21, 2019 · 6 comments
Closed

Coverage overlay for PRs #23

jarekwg opened this issue Mar 21, 2019 · 6 comments

Comments

@jarekwg
Copy link

jarekwg commented Mar 21, 2019

Related to #10,
But would be really awesome to have the overlay on the diff overview for PRs.
ie on this page https://github.com/<org>/<repo>/pull/<#pr>/files

The old codecov extension offered this and it was amazing. After submitting a PR, one could see which lines of the code they'd touched were covered.

It was especially nice how it'd continue to use a darker green/red highlighting in the line number gutter to indicate which lines were added/removed, whilst the lighter green/red highlighting across the actual code indicated what lines were covered by tests.

All the best. :)

@felixfbecker
Copy link
Collaborator

This depends on sourcegraph/sourcegraph#911, I have a WIP prototype PR up at sourcegraph/sourcegraph#911

@felixfbecker
Copy link
Collaborator

Hi @jarekwg, this is supported now 🎉
You can see it in action in our announcement blog post: https://about.sourcegraph.com/blog/sourcegraph-3.5#improved-code-reviews-with-line-decorations-in-pull-requests

@jarekwg
Copy link
Author

jarekwg commented Jul 11, 2019

Awesome stuff! Thanks! Will jump onto it quicksmart.

@jberryman
Copy link

Where would I find docs on this? Videos in that blog are broken

@dkrotx-test
Copy link

As I understand this is now deprecated. Any plans on resurrecting this amazing overlay feature?

@thomasrockhu
Copy link
Contributor

@dkrotx-test we are starting to look at creating an overlay feature. You can follow along here

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants