Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Quoted font-family-names get destroyed #21

Closed
jazzynico opened this issue Dec 5, 2015 · 1 comment
Closed

Quoted font-family-names get destroyed #21

jazzynico opened this issue Dec 5, 2015 · 1 comment
Labels

Comments

@jazzynico
Copy link

(Original report in https://bugs.launchpad.net/scour/+bug/1514073)

Font-family-names like "'MyriadPro-Regular'" get converted to "'MyriadPro-Regular'" with HTML-Entitys (primary fonts with whitespaces, because single quotation marks are recommended for this by the W3C) if you save as Optimzed SVG. Tested on Windows 7 x64 and Ubuntu latest version.

Inkscape 0.91 r13725
includes Scour 0.26+r220

Also reproduced on Xubuntu 15.10 with Scour 0.31 (as a standalone script).
Test file available in the original report (unfortunately GH doesn't support SVG attachments...).

@oberstet oberstet added the bug label Dec 10, 2015
Ede123 added a commit to Ede123/scour that referenced this issue Aug 15, 2016
- In text nodes quotes are fine
- In attributes quotes are fine if used reciprocally.

Escaping in the latter case often causes issues, e.g. with quoted font names (scour-project#21) or inline CSS styles (scour-project#56), while it probably does not gain anything (if quotes are wrongly used in attribute names the XML is most likely invalid to start with)
Ede123 added a commit that referenced this issue Aug 15, 2016
- In text nodes quotes are fine
- In attributes quotes are fine if used reciprocally.

Escaping in the latter case often causes issues, e.g. with quoted font names (#21) or inline CSS styles (#56), while it probably does not gain anything (if quotes are wrongly used in attribute names the XML is most likely invalid to start with)
@Ede123
Copy link
Member

Ede123 commented Aug 15, 2016

Fixed in 57f93ef
Keep an eye open for regressions, since we're not escaping quotes ('/") in text nodes and attributes anymore.

@Ede123 Ede123 closed this as completed Aug 15, 2016
mfwitten added a commit to mfwitten/scour that referenced this issue Aug 27, 2017
mfwitten added a commit to mfwitten/scour that referenced this issue Aug 27, 2017
mfwitten added a commit to mfwitten/scour that referenced this issue Aug 28, 2017
mfwitten added a commit to mfwitten/scour that referenced this issue Aug 28, 2017
mfwitten added a commit to mfwitten/scour that referenced this issue Aug 28, 2017
mfwitten added a commit to mfwitten/scour that referenced this issue Aug 28, 2017
Ede123 pushed a commit that referenced this issue Sep 3, 2017
These tests will ensure that issues #21 and #56 do not return.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants