Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

馃悶 Clicking disclosure button next to folder doesn't animate open #45

Closed
austincondiff opened this issue Mar 17, 2022 · 1 comment
Closed
Labels
bug Something isn't working performance This is performance related UI This is UI related

Comments

@austincondiff
Copy link
Collaborator

When clicking the disclosure button next to a folder, it doesn't animate open but it animates closed. It needs to animate open as well.

@austincondiff austincondiff added the bug Something isn't working label Mar 17, 2022
@lukepistrol lukepistrol linked a pull request Mar 18, 2022 that will close this issue
@lukepistrol lukepistrol added the UI This is UI related label Mar 20, 2022
@lukepistrol lukepistrol removed a link to a pull request Mar 20, 2022
@lukepistrol
Copy link
Member

To learn more about current state see #61

TLDR: Doing it the right way (from an SwiftUI perspective) comes with major performance losses due to reloading of all files when selecting a file (even collapsed ones). The current state does not render collapsed file items.

@lukepistrol lukepistrol added the performance This is performance related label Mar 20, 2022
@lukepistrol lukepistrol changed the title Clicking disclosure button next to folder doesn't animate open [BUG] - Clicking disclosure button next to folder doesn't animate open Mar 21, 2022
@austincondiff austincondiff changed the title [BUG] - Clicking disclosure button next to folder doesn't animate open 馃悶 Clicking disclosure button next to folder doesn't animate open Mar 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working performance This is performance related UI This is UI related
Projects
Status: 馃弫 Complete
Development

No branches or pull requests

2 participants