-
-
Notifications
You must be signed in to change notification settings - Fork 976
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🐞 Fix Toolbar and Tabs Style Differences #49
Comments
I am trying to figure out how to fix the toolbar portion right now, I will look at the tab bar after. |
I am working on improving the tab item styling and animation (to follow the design of Xcode, and add a configurable option to generally switch between two styles). Do we need to leave some APIs for the theming of tab item? |
No APIs at the moment. Did you have anything particular in mind? |
Look at |
I think this can be closed. @austincondiff |
The toolbar is nearly white in Xcode and Finder in light mode while in CodeEdit it is light gray.
The toolbar is lighter gray in Xcode and Finder in dark mode while in CodeEdit it is a darker gray.
Notice the difference in tabs on both light and dark mode compared to Finder. We are opting for a more native tab style so that needs to look exactly like native tabs found in Finder. At some point it may be nice to have a setting to toggle between native style or Xcode style tabs.
Also notice the vibrancy effects, hover states and transition effects.
Screen.Recording.2022-03-18.at.1.04.36.AM.mp4
The text was updated successfully, but these errors were encountered: