Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐞 Fix Toolbar and Tabs Style Differences #49

Closed
austincondiff opened this issue Mar 18, 2022 · 5 comments
Closed

🐞 Fix Toolbar and Tabs Style Differences #49

austincondiff opened this issue Mar 18, 2022 · 5 comments
Labels
bug Something isn't working tabs UI This is UI related workspace

Comments

@austincondiff
Copy link
Collaborator

austincondiff commented Mar 18, 2022

The toolbar is nearly white in Xcode and Finder in light mode while in CodeEdit it is light gray.

image

image

image

The toolbar is lighter gray in Xcode and Finder in dark mode while in CodeEdit it is a darker gray.

image

image

image

Notice the difference in tabs on both light and dark mode compared to Finder. We are opting for a more native tab style so that needs to look exactly like native tabs found in Finder. At some point it may be nice to have a setting to toggle between native style or Xcode style tabs.

Also notice the vibrancy effects, hover states and transition effects.

Screen.Recording.2022-03-18.at.1.04.36.AM.mp4
@austincondiff austincondiff added the bug Something isn't working label Mar 18, 2022
@highjeans
Copy link
Contributor

I am trying to figure out how to fix the toolbar portion right now, I will look at the tab bar after.

@lukepistrol lukepistrol added the UI This is UI related label Mar 20, 2022
@lukepistrol lukepistrol changed the title Fix Toolbar and Tabs Style Differences [BUG] - Fix Toolbar and Tabs Style Differences Mar 21, 2022
@austincondiff austincondiff changed the title [BUG] - Fix Toolbar and Tabs Style Differences 🐞 Fix Toolbar and Tabs Style Differences Mar 31, 2022
@lilingxi01
Copy link
Member

I am working on improving the tab item styling and animation (to follow the design of Xcode, and add a configurable option to generally switch between two styles).

Do we need to leave some APIs for the theming of tab item?

@austincondiff
Copy link
Collaborator Author

No APIs at the moment. Did you have anything particular in mind?

@austincondiff
Copy link
Collaborator Author

austincondiff commented Apr 15, 2022

Look at SegmentedControl for the background color. I believe it is .selectedControl at 0.75 opacity. I also had to make the text color .accentColor in light mode (.primary in dark mode).

@lilingxi01
Copy link
Member

I think this can be closed. @austincondiff

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working tabs UI This is UI related workspace
Projects
Status: 🏁 Complete
Development

No branches or pull requests

4 participants