Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change open to line and column syntax #16

Closed
austincondiff opened this issue Dec 6, 2022 · 2 comments
Closed

Change open to line and column syntax #16

austincondiff opened this issue Dec 6, 2022 · 2 comments
Assignees
@lukepistrol

Comments

@austincondiff
Copy link
Contributor

austincondiff commented Dec 6, 2022 •
edited
Loading

Instead of

codeedit-cli Example.swift -l 43 -c 10

can we instead do something like...

codeedit Example.swift:43:10
  • Change codeedit-cli to codeedit
  • instead of -l and -c, the filename line and column are separated by :

This seems to be standard and is the case with VS Codes CLI. See their documentation on open for reference.
@lukepistrol lukepistrol self-assigned this Dec 6, 2022
@lukepistrol
Copy link
Member

regarding renaming codeedit-cli to codeedit:

I think we should leave it as codeedit-cli, so that it is clear what the binary does. When a user likes to use codeedit instead they can easily create an alias for that. Also it might bring confusion once we want to bring both CodeEdit and the CLI to homebrew. codeedit-cli is just more describing imo

@lukepistrol lukepistrol mentioned this issue Dec 6, 2022
Merged
austincondiff added a commit that referenced this issue Dec 7, 2022
@austincondiff
[fix]: line & column parameters (#17)
eed72c0 
As proposed in #16 the syntax to open a file at specified line and
column has changed:

```sh
# Prior
codeedit-cli index.html -l 42 -c 4

# New
codeedit-cli index.html:42:4
```
@austincondiff
Copy link
Contributor Author

Closing this issue. Creating a separate issue to address the name change. @lukepistrol feel free to re-comment there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lukepistrol lukepistrol

Labels
None yet
Projects
CodeEdit Project
Status: 🏁 Complete
Milestone
No milestone
Development

No branches or pull requests
2 participants
@austincondiff @lukepistrol