Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

iOS 10 beta 5,6 でフリックポップアップが重い #152

Closed
banjun opened this issue Aug 11, 2016 · 3 comments

Comments

Projects
None yet
1 participant
@banjun
Copy link
Member

commented Aug 11, 2016

iOS 10 beta 4までは問題なかった。要解析。

@banjun banjun added the UI label Aug 11, 2016

@banjun

This comment has been minimized.

Copy link
Member Author

commented Aug 11, 2016

フリック中のKeyPadのKeyButtonのラベル変更がレイアウトのエラーと、重いレイアウトを発生させているらしい。
さしあたりの非再現化パッチは本質的にはこれっぽい?

--- a/FlickSKKKeyboard/KeyButton.swift
+++ b/FlickSKKKeyboard/KeyButton.swift
@@ -21,7 +21,7 @@ class KeyButton: UIView, UIGestureRecognizerDelegate {
                 let text = String(Array(s)[self.sequenceIndex ?? 0])
                 // FIXME: special ignore label
                 if(text != KanaFlickKey.ignoredSequence) {
-                    self.label.text = text
+//                    self.label.text = text
                 }
             }
         }
@banjun

This comment has been minimized.

Copy link
Member Author

commented Aug 15, 2016

iOS 10 beta 6でも重い

@banjun banjun changed the title iOS 10 beta 5 でフリックポップアップが重い iOS 10 beta 5,6 でフリックポップアップが重い Aug 15, 2016

@banjun banjun modified the milestones: 1。4。3, 1.4.3 Aug 30, 2016

@banjun

This comment has been minimized.

Copy link
Member Author

commented Sep 7, 2016

iOS 10 GM (iOS 10.0.1 GMらしい?)でも重いことを確認し,FlickSKK 1.4.3でApp Storeリリース済み

@banjun banjun closed this Sep 7, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.